linux-kernel - Re: [PATCH] ASoC: madera: Use str_enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z3v+o8NKvr+Z236V@opensource.cirrus.com>
Date: Mon, 6 Jan 2025 16:02:43 +0000
From: Charles Keepax <ckeepax@...nsource.cirrus.com>
To: Thorsten Blum <thorsten.blum@...ux.dev>
CC: Richard Fitzgerald <rf@...nsource.cirrus.com>,
        Liam Girdwood
	<lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>,
        Jaroslav Kysela
	<perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
        <linux-sound@...r.kernel.org>, <patches@...nsource.cirrus.com>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ASoC: madera: Use str_enabled_disabled() helper function

On Sun, Dec 29, 2024 at 06:40:44PM +0100, Thorsten Blum wrote:
> Remove hard-coded strings by using the str_enabled_disabled() helper
> function.
> 
> Signed-off-by: Thorsten Blum <thorsten.blum@...ux.dev>
> ---
>  sound/soc/codecs/madera.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/sound/soc/codecs/madera.c b/sound/soc/codecs/madera.c
> index b24d6472ad5f..86abfbe56e1f 100644
> --- a/sound/soc/codecs/madera.c
> +++ b/sound/soc/codecs/madera.c
> @@ -3965,7 +3965,7 @@ static int madera_enable_fll(struct madera_fll *fll)
>  	}
>  
>  	madera_fll_dbg(fll, "Enabling FLL, initially %s\n",
> -		       already_enabled ? "enabled" : "disabled");
> +		       str_enabled_disabled(already_enabled));
>  
>  	if (fll->fout < MADERA_FLL_MIN_FOUT ||
>  	    fll->fout > MADERA_FLL_MAX_FOUT) {
> @@ -4252,7 +4252,7 @@ static int madera_enable_fll_ao(struct madera_fll *fll,
>  		pm_runtime_get_sync(madera->dev);
>  
>  	madera_fll_dbg(fll, "Enabling FLL_AO, initially %s\n",
> -		       already_enabled ? "enabled" : "disabled");
> +		       str_enabled_disabled(already_enabled));
>  
>  	/* FLL_AO_HOLD must be set before configuring any registers */
>  	regmap_update_bits(fll->madera->regmap,
> @@ -4576,7 +4576,7 @@ static int madera_fllhj_enable(struct madera_fll *fll)
>  		pm_runtime_get_sync(madera->dev);
>  
>  	madera_fll_dbg(fll, "Enabling FLL, initially %s\n",
> -		       already_enabled ? "enabled" : "disabled");
> +		       str_enabled_disabled(already_enabled));
>  
>  	/* FLLn_HOLD must be set before configuring any registers */
>  	regmap_update_bits(fll->madera->regmap,

This should also add an include for the string_choices header,
but otherwise looks fine to me.

Thanks,
Charles