linux-kernel - Re: [PATCH] x86/sev: Don't hang but terminate on failure to remap SVSM CA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMj1kXFCNc0q1b6S7ymgfBMuGWVPjbUZW3+4Ny5b3r9=3-z92g@mail.gmail.com>
Date: Mon, 6 Jan 2025 17:28:28 +0100
From: Ard Biesheuvel <ardb@...nel.org>
To: Tom Lendacky <thomas.lendacky@....com>
Cc: Ard Biesheuvel <ardb+git@...gle.com>, linux-kernel@...r.kernel.org, x86@...nel.org
Subject: Re: [PATCH] x86/sev: Don't hang but terminate on failure to remap
 SVSM CA

On Mon, 6 Jan 2025 at 17:10, Tom Lendacky <thomas.lendacky@....com> wrote:
>
> On 1/6/25 09:57, Ard Biesheuvel wrote:
> > From: Ard Biesheuvel <ardb@...nel.org>
> >
> > Commit
> >
> >   09d35045cd0f  ("x86/sev: Avoid WARN()s and panic()s in early boot code")
> >
> > replaced a panic() that could potentially hit before the kernel is even
> > mapped with a deadloop, to ensure that execution does not proceed when
> > the condition in question hits.
> >
> > As Tom suggests, it is better to terminate and return to the hypervisor
> > in this case, using a newly invented failure code to describe the
> > failure condition.
> >
> > Suggested-by: Tom Lendacky <thomas.lendacky@....com>
> > Link: https://lore.kernel.org/all/9ce88603-20ca-e644-2d8a-aeeaf79cde69@amd.com
> > Signed-off-by: Ard Biesheuvel <ardb@...nel.org>
>
> Sorry Ard, I hadn't realized that the series was already merged or I
> would have submitted the patch myself. Thanks for doing this!
>

No worries


> Reviewed-by: Tom Lendacky <thomas.lendacky@....com>
>

Thanks