linux-kernel - Re: [PATCH v3 1/6] dt-bindings: PCI: Add binding for qps615

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d4019981-1df2-0946-d093-7dc97c2d0ffe@quicinc.com>
Date: Tue, 7 Jan 2025 19:58:17 +0530
From: Krishna Chaitanya Chundru <quic_krichai@...cinc.com>
To: Rob Herring <robh@...nel.org>
CC: <andersson@...nel.org>, Bjorn Helgaas <bhelgaas@...gle.com>,
        "Dmitry
 Baryshkov" <dmitry.baryshkov@...aro.org>,
        Lorenzo Pieralisi
	<lpieralisi@...nel.org>,
        Krzysztof Wilczyński
	<kw@...ux.com>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley
	<conor+dt@...nel.org>,
        Konrad Dybcio <konradybcio@...nel.org>,
        "Manivannan
 Sadhasivam" <manivannan.sadhasivam@...aro.org>,
        <cros-qcom-dts-watchers@...omium.org>,
        Jingoo Han <jingoohan1@...il.com>, Bartosz Golaszewski <brgl@...ev.pl>,
        <quic_vbadigan@...cinc.com>, <linux-arm-msm@...r.kernel.org>,
        <linux-pci@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 1/6] dt-bindings: PCI: Add binding for qps615



On 12/30/2024 11:52 PM, Manivannan Sadhasivam wrote:
> On Mon, Dec 23, 2024 at 08:57:37PM +0200, Dmitry Baryshkov wrote:
> 
> [...]
> 
>>> This switch allows us to configure both upstream, downstream ports and
>>> also embedded Ethernet port which is internal to the switch. These
>>> properties are applicable for all of those.
>>>>> +
>>>>> +    allOf:
>>>>> +      - $ref: /schemas/pci/pci-bus.yaml#
>>>>
>>>> pci-pci-bridge.yaml is more specific and closer to what this device is.
>>>>
>>> I tried this now, I was getting warning saying the compatible
>>> /local/mnt/workspace/skales/kobj/Documentation/devicetree/bindings/pci/qcom,qps615.example.dtb:
>>> pcie@0,0: compatible: ['pci1179,0623'] does not contain items matching the
>>> given schema
>>>          from schema $id: http://devicetree.org/schemas/pci/qcom,qps615.yaml#
>>> /local/mnt/workspace/skales/kobj/Documentation/devicetree/bindings/pci/qcom,qps615.example.dtb:
>>> pcie@0,0: Unevaluated properties are not allowed ('#address-cells',
>>> '#size-cells', 'bus-range', 'device_type', 'ranges' were unexpected)
>>>
>>> I think pci-pci-bridge is expecting the compatible string in this format
>>> only "pciclass,0604".
>>
>> I think the pci-pci-bridge schema requires to have "pciclass,0604" among
>> other compatibles. So you should be able to do something like:
>>
>> compatible = "pci1179,0623", "pciclass,0604";
>>
> 
> Even though a PCIe switch is supposed to be a network of PCI bridges, using
> PCI bridge fallback for this switch is not technically correct IMO. Mostly
> because, this switch requires other configurations which are not applicable to
> PCI bridges. So the drivers matching against the bridge compatible won't be able
> to use this switch.
> 
> - Mani
Rob,

Using pci-pci-bridge expects to use compatible as pciclass,0604, we
can't  use as this switch is doing other configurations which are
applicable to PCI bridges. can we continue to use pci-bus.yaml.

- Krishna Chaitanya.
>