linux-kernel - Re: [PATCH v3 3/6] powwerpc: Use note name macros

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ceb65b63-3b16-490b-adfb-daf8838bb54a@cs-soprasteria.com>
Date: Tue, 7 Jan 2025 14:37:42 +0000
From: LEROY Christophe <christophe.leroy2@...soprasteria.com>
To: Akihiko Odaki <akihiko.odaki@...nix.com>, Eric Biederman
	<ebiederm@...ssion.com>, Kees Cook <kees@...nel.org>, Catalin Marinas
	<catalin.marinas@....com>, Mark Brown <broonie@...nel.org>, Dave Martin
	<Dave.Martin@....com>, Baoquan He <bhe@...hat.com>, Vivek Goyal
	<vgoyal@...hat.com>, Dave Young <dyoung@...hat.com>
CC: "linux-mm@...ck.org" <linux-mm@...ck.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "linuxppc-dev@...ts.ozlabs.org"
	<linuxppc-dev@...ts.ozlabs.org>, "linux-s390@...r.kernel.org"
	<linux-s390@...r.kernel.org>, "kexec@...ts.infradead.org"
	<kexec@...ts.infradead.org>, "binutils@...rceware.org"
	<binutils@...rceware.org>, "devel@...nix.com" <devel@...nix.com>
Subject: Re: [PATCH v3 3/6] powwerpc: Use note name macros


Le 07/01/2025 à 13:45, Akihiko Odaki a écrit :
> Use note name macros to match with the userspace's expectation.

In the subject:

s/powwerpc/powerpc

Christophe


> 
> Acked-by: Baoquan He <bhe@...hat.com>
> Signed-off-by: Akihiko Odaki <akihiko.odaki@...nix.com>
> ---
>   arch/powerpc/kernel/fadump.c               | 2 +-
>   arch/powerpc/platforms/powernv/opal-core.c | 8 ++++----
>   2 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/arch/powerpc/kernel/fadump.c b/arch/powerpc/kernel/fadump.c
> index 4b371c738213..d44349fe8e2b 100644
> --- a/arch/powerpc/kernel/fadump.c
> +++ b/arch/powerpc/kernel/fadump.c
> @@ -751,7 +751,7 @@ u32 *__init fadump_regs_to_elf_notes(u32 *buf, struct pt_regs *regs)
>   	 * prstatus.pr_pid = ????
>   	 */
>   	elf_core_copy_regs(&prstatus.pr_reg, regs);
> -	buf = append_elf_note(buf, CRASH_CORE_NOTE_NAME, NT_PRSTATUS,
> +	buf = append_elf_note(buf, NN_PRSTATUS, NT_PRSTATUS,
>   			      &prstatus, sizeof(prstatus));
>   	return buf;
>   }
> diff --git a/arch/powerpc/platforms/powernv/opal-core.c b/arch/powerpc/platforms/powernv/opal-core.c
> index c9a9b759cc92..a379ff86c120 100644
> --- a/arch/powerpc/platforms/powernv/opal-core.c
> +++ b/arch/powerpc/platforms/powernv/opal-core.c
> @@ -149,7 +149,7 @@ static Elf64_Word *__init auxv_to_elf64_notes(Elf64_Word *buf,
>   	/* end of vector */
>   	bufp[idx++] = cpu_to_be64(AT_NULL);
>   
> -	buf = append_elf64_note(buf, CRASH_CORE_NOTE_NAME, NT_AUXV,
> +	buf = append_elf64_note(buf, NN_AUXV, NT_AUXV,
>   				oc_conf->auxv_buf, AUXV_DESC_SZ);
>   	return buf;
>   }
> @@ -252,7 +252,7 @@ static Elf64_Word * __init opalcore_append_cpu_notes(Elf64_Word *buf)
>   	 * crashing CPU's prstatus.
>   	 */
>   	first_cpu_note = buf;
> -	buf = append_elf64_note(buf, CRASH_CORE_NOTE_NAME, NT_PRSTATUS,
> +	buf = append_elf64_note(buf, NN_PRSTATUS, NT_PRSTATUS,
>   				&prstatus, sizeof(prstatus));
>   
>   	for (i = 0; i < oc_conf->num_cpus; i++, bufp += size_per_thread) {
> @@ -279,7 +279,7 @@ static Elf64_Word * __init opalcore_append_cpu_notes(Elf64_Word *buf)
>   		fill_prstatus(&prstatus, thread_pir, &regs);
>   
>   		if (thread_pir != oc_conf->crashing_cpu) {
> -			buf = append_elf64_note(buf, CRASH_CORE_NOTE_NAME,
> +			buf = append_elf64_note(buf, NN_PRSTATUS,
>   						NT_PRSTATUS, &prstatus,
>   						sizeof(prstatus));
>   		} else {
> @@ -287,7 +287,7 @@ static Elf64_Word * __init opalcore_append_cpu_notes(Elf64_Word *buf)
>   			 * Add crashing CPU as the first NT_PRSTATUS note for
>   			 * GDB to process the core file appropriately.
>   			 */
> -			append_elf64_note(first_cpu_note, CRASH_CORE_NOTE_NAME,
> +			append_elf64_note(first_cpu_note, NN_PRSTATUS,
>   					  NT_PRSTATUS, &prstatus,
>   					  sizeof(prstatus));
>   		}
>