linux-kernel - Re: [PATCH 2/3] PCI: of: Simplify bus range parsing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL_JsqJjUyV8vr7HkcV4yneo6KNw2QRzxYmTXiNCk524KudCvw@mail.gmail.com>
Date: Tue, 7 Jan 2025 08:46:12 -0600
From: Rob Herring <robh@...nel.org>
To: Bjorn Helgaas <helgaas@...nel.org>
Cc: "David S . Miller" <davem@...emloft.net>, Andreas Larsson <andreas@...sler.com>, sparclinux@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-pci@...r.kernel.org, 
	Bjorn Helgaas <bhelgaas@...gle.com>
Subject: Re: [PATCH 2/3] PCI: of: Simplify bus range parsing

On Fri, Jan 3, 2025 at 3:38 PM Bjorn Helgaas <helgaas@...nel.org> wrote:
>
> On Fri, Jan 03, 2025 at 03:31:28PM -0600, Bjorn Helgaas wrote:
> > From: Bjorn Helgaas <bhelgaas@...gle.com>
> >
> > of_pci_parse_bus_range() looks for a DT "bus-range" property.  If none
> > exists, devm_of_pci_get_host_bridge_resources() defaults to the [bus 00-ff]
> > range supplied by its caller, pci_parse_request_of_pci_ranges().
> >
> > devm_of_pci_get_host_bridge_resources() is static and has no other callers,
> > so there's no reason to complicate its interface by passing the default bus
> > range.
> >
> > Drop the busno and bus_max parameters and use 0x0 and 0xff directly in
> > devm_of_pci_get_host_bridge_resources().
>
> Since we default this if the DT lacks "bus-range", is there any point
> in repeating "bus-range = <0x00 0xff>;" in all the host bridge
> descriptions?

No. And I tell people to drop it if that's what they have.

Rob