linux-kernel - Re: [PATCH v4 2/4] arm64: dts: morello: Add support for common functionalities

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c6ac20ec-f979-4028-9488-f453953a43b5@arm.com>
Date: Tue, 7 Jan 2025 14:49:56 +0000
From: Vincenzo Frascino <vincenzo.frascino@....com>
To: Jessica Clarke <jrtc27@...c27.com>
Cc: devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org,
 Linus Walleij <linus.walleij@...aro.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Liviu Dudau <liviu.dudau@....com>,
 Sudeep Holla <sudeep.holla@....com>,
 Lorenzo Pieralisi <lpieralisi@...nel.org>,
 Russell King <linux@...linux.org.uk>
Subject: Re: [PATCH v4 2/4] arm64: dts: morello: Add support for common
 functionalities



[...]

>> +
>> +		soc_refclk85mhz: clock-85000000 {
>> +			compatible = "fixed-clock";
>> +			#clock-cells = <0>;
>> +			clock-frequency = <85000000>;
>> +			clock-output-names = "iofpga:aclk";
> 
> If this is ACLK for the IOFPGA outside the SoC, why is it called soc_refclk85mhz?
> 
> Not that it seems to be used in this patch series.
>

Good catch.

Indeed, it is not used in this series and the name and placement are incorrect.

I can either rename it and move it to the board file or remove it and add it
again in future.

[...]

>> +
>> +		i2c0: i2c@...f0000 {
> 
> The I2C controller lives in the IOFGPA on the board, not the SoC.
> 
>> +			compatible = "cdns,i2c-r1p14";
>> +			reg = <0x0 0x1c0f0000 0x0 0x1000>;
>> +			interrupts = <GIC_SPI 138 IRQ_TYPE_LEVEL_HIGH>;
>> +			clocks = <&dpu_aclk>;
>> +
>> +			#address-cells = <1>;
>> +			#size-cells = <0>;
>> +
>> +			status = "disabled";
>> +
>> +			hdmi_tx: hdmi-transmitter@70 {
> 
> The transmitter is a discrete chip on the board, not the SoC.
>

Agreed on both the points, please have a look at my reply to Rob.

> Jess

[...]
-- 
Regards,
Vincenzo