linux-kernel - Re: [PATCH v5 1/4] dt-bindings: vendor-prefixes: Add NetCube Systems Austria name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250107145446.16a8a4ea@donnerap.manchester.arm.com>
Date: Tue, 7 Jan 2025 14:54:46 +0000
From: Andre Przywara <andre.przywara@....com>
To: Lukas Schmid <lukas.schmid@...cube.li>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Chen-Yu Tsai <wens@...e.org>, Jernej
 Skrabec <jernej.skrabec@...il.com>, Samuel Holland <samuel@...lland.org>,
 Maxime Ripard <mripard@...nel.org>, devicetree@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-sunxi@...ts.linux.dev,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 1/4] dt-bindings: vendor-prefixes: Add NetCube
 Systems Austria name

On Mon,  6 Jan 2025 19:06:59 +0000
Lukas Schmid <lukas.schmid@...cube.li> wrote:

> NetCube Systems Austria builds Embedded Systems for use in IoT, IIoT,
> or Smart Home scenarios.
> 
> Website is still WIP, but the Links on it are active:
> https://netcubesystems.at/
> 
> Signed-off-by: Lukas Schmid <lukas.schmid@...cube.li>

Just to give some more guidance on when to drop tags and when to not:
If you are making real changes to the code, then it might be indicated to
drop the tag, since the patch might not be anymore what the reviewer
acknowledged.
But if you are just fixing (especially improving/adding to) the commit
message, or fixing some typo, then you keep the tag, to reduce the churn
and avoid extra work again from the reviewer.
This is sometimes not easy to decide, say for instance: is renaming a
variable something covered by the tag? The new name might be worse or
misleading, even though the code didn't really change.

But in this case it's pretty clear that Krzysztof is surely fine with you
adding extra info to the commit message, and the actual patch didn't
change at all, so keeping his tag would be a good thing.

If you are in doubt, then it's often good to drop the tag *and* point this
out, for instance in the cover letter, like: "Krzysztof, I changed this
and that in patch 1/4, so I dropped your tag."

Cheers,
Andre

> ---
>  Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> index da01616802c7..a30ed9547098 100644
> --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
> +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> @@ -1027,6 +1027,8 @@ patternProperties:
>      description: Neofidelity Inc.
>    "^neonode,.*":
>      description: Neonode Inc.
> +  "^netcube,.*":
> +    description: NetCube Systems Austria
>    "^netgear,.*":
>      description: NETGEAR
>    "^netlogic,.*":