linux-kernel - Re: [PATCH v3] vbox: Enable VBOXGUEST and VBOXSF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7854ef21-0a4f-4afa-a1f7-90e5cec19032@redhat.com>
Date: Tue, 7 Jan 2025 16:16:44 +0100
From: Hans de Goede <hdegoede@...hat.com>
To: Christian Kujau <lists@...dbynature.de>
Cc: Arnd Bergmann <arnd@...db.de>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org,
 linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH v3] vbox: Enable VBOXGUEST and VBOXSF_FS on ARM64

Hi Christian,

On 7-Jan-25 4:01 PM, Christian Kujau wrote:
> Now that VirtualBox is able to run as a host on arm64 (e.g. the Apple M3 
> processors) we can enable VBOXSF_FS (and in turn VBOXGUEST) for this 
> architecture. Tested with various runs of bonnie++ and dbench on an Apple 
> MacBook Pro with the latest Virtualbox 7.1.4 r165100 installed.
> 
> Signed-off-by: Christian Kujau <lists@...dbynature.de>
> Reviewed-by: Hans de Goede <hdegoede@...hat.com>

Thank you for the new version, note that v2 has already been applied
to the vfs tree though.

This is fine, the missing changelog is really not a big deal and
the changelog gets dropped on applying the patch anyways.

So this is all merged up now.

Regards,

Hans




> 
> ---
> v3: version history added, along with Hans' Reviewed-by
> 
> v2: vboxvideo change removed, see:
>     https://lore.kernel.org/lkml/7384d96c-2a77-39b0-2306-90129bae9342@nerdbynature.de/
> 
> v1: initial version, see:
>     https://lore.kernel.org/lkml/a969298e-0986-470c-9711-703af784d672@redhat.com/
> 
>  drivers/virt/vboxguest/Kconfig | 2 +-
>  fs/vboxsf/Kconfig              | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/virt/vboxguest/Kconfig b/drivers/virt/vboxguest/Kconfig
> index cc329887bfae..11b153e7454e 100644
> --- a/drivers/virt/vboxguest/Kconfig
> +++ b/drivers/virt/vboxguest/Kconfig
> @@ -1,7 +1,7 @@
>  # SPDX-License-Identifier: GPL-2.0-only
>  config VBOXGUEST
>  	tristate "Virtual Box Guest integration support"
> -	depends on X86 && PCI && INPUT
> +	depends on (ARM64 || X86) && PCI && INPUT
>  	help
>  	  This is a driver for the Virtual Box Guest PCI device used in
>  	  Virtual Box virtual machines. Enabling this driver will add
> diff --git a/fs/vboxsf/Kconfig b/fs/vboxsf/Kconfig
> index b84586ae08b3..d4694026db8b 100644
> --- a/fs/vboxsf/Kconfig
> +++ b/fs/vboxsf/Kconfig
> @@ -1,6 +1,6 @@
>  config VBOXSF_FS
>  	tristate "VirtualBox guest shared folder (vboxsf) support"
> -	depends on X86 && VBOXGUEST
> +	depends on (ARM64 || X86) && VBOXGUEST
>  	select NLS
>  	help
>  	  VirtualBox hosts can share folders with guests, this driver
>