linux-kernel - Re: [PATCH 1/3] Revert "staging: remove rts5139 driver code"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2025010718-tamale-eraser-4c49@gregkh>
Date: Tue, 7 Jan 2025 16:27:32 +0100
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Sean Rhodes <sean@...rlabs.systems>
Cc: linux-kernel@...r.kernel.org, stable@...r.kernel.org,
	Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH 1/3] Revert "staging: remove rts5139 driver code"

On Tue, Nov 19, 2024 at 12:19:10PM +0000, Sean Rhodes wrote:
> This reverts commit 00d8521dcd236d1b8f664f54a0309e96bfdcb4f9.
> 
> The staging driver that was removed, `rts5139`, worked well with multiple
> Realtek card readers and provided more comprehensive functionality than
> `rtsx_usb`. It supported features like interrupts, SSC, speed modes,
> suspend, secure erase, TRIM, and more. Additionally, its error recovery
> mechanisms were superior.
> 
> Notable issues with the `rtsx_usb` driver include delayed S3 entry until
> `mmc_rescan` was frozen and data corruption on SDR104 cards. Over 100 bugs
> related to the `rtsx_usb` driver are reported on Bugzilla, with additional
> reports downstream. As a result, several forks of `rts5139` exist on
> GitHub and other repositories, which users rely on to mitigate these
> problems.
> 
> Reintroducing `rts5139` addresses these deficiencies until the current
> `rtsx_usb` driver achieves feature parity and stability.
> 
> Fixes: 00d8521dcd23 ("staging: remove rts5139 driver code")
> Cc: stable@...r.kernel.org

Sorry, but this isn't a stable patch, it's "add a whole new driver".

Also, who is now going to take over maintaining this driver?  There's
still a lot of things left on the TODO list:

> --- /dev/null
> +++ b/drivers/staging/rts5139/TODO
> @@ -0,0 +1,9 @@
> +TODO:
> +- support more USB card reader of Realtek family
> +- use kernel coding style
> +- checkpatch.pl fixes
> +- stop having thousands of lines of code duplicated with staging/rts_pstor
> +- This driver contains an entire SD/MMC stack -- it should use the stack in
> +  drivers/mmc instead, as a host driver e.g. drivers/mmc/host/realtek-usb.c;
> +  see drivers/mmc/host/ushc.c as an example.
> +- This driver presents cards as SCSI devices, but they should be MMC devices.

The biggest issue is the whole mmc stack being in here.  When is that
work going to happen?  Why not just add the missing features to the
existing misc/ drivers instead?

I'll be glad to add this back, but I need someone to take ownership of
it in order to fix this and get it out of staging.  Please feel free to
resend this series with that information.

thanks,

greg k-h