linux-kernel - Re: [PATCH v2] platform/x86/amd/pmc: Only disable IRQ1 wakeup where i8042 actually enabled it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <173626558051.4330.18326031399092092467.b4-ty@linux.intel.com>
Date: Tue, 07 Jan 2025 17:59:40 +0200
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: Shyam Sundar S K <Shyam-sundar.S-k@....com>, 
 Mario Limonciello <mario.limonciello@....com>, 
 "Maciej S. Szmigiero" <mail@...iej.szmigiero.name>
Cc: Hans de Goede <hdegoede@...hat.com>, 
 platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] platform/x86/amd/pmc: Only disable IRQ1 wakeup
 where i8042 actually enabled it

On Mon, 06 Jan 2025 18:40:34 +0100, Maciej S. Szmigiero wrote:

> Wakeup for IRQ1 should be disabled only in cases where i8042 had actually
> enabled it, otherwise "wake_depth" for this IRQ will try to drop below zero
> and there will be an unpleasant WARN() logged:
> kernel: atkbd serio0: Disabling IRQ1 wakeup source to avoid platform firmware bug
> kernel: ------------[ cut here ]------------
> kernel: Unbalanced IRQ 1 wake disable
> kernel: WARNING: CPU: 10 PID: 6431 at kernel/irq/manage.c:920 irq_set_irq_wake+0x147/0x1a0
> 
> [...]

Thank you for your contribution, it has been applied to my local
review-ilpo-fixes branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-fixes branch only once I've pushed my
local branch there, which might take a while.

The list of commits applied:
[1/1] platform/x86/amd/pmc: Only disable IRQ1 wakeup where i8042 actually enabled it
      commit: dd410d784402c5775f66faf8b624e85e41c38aaf

--
 i.