linux-kernel - Re: [PATCH] platform/x86/intel/pmc: Fix ioremap of bad address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <173626559524.4330.18207834156877167581.b4-ty@linux.intel.com>
Date: Tue, 07 Jan 2025 17:59:55 +0200
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: irenic.rajneesh@...il.com, david.e.box@...el.com, hdegoede@...hat.com, 
 platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org, 
 xi.pardee@...ux.intel.com, "David E. Box" <david.e.box@...ux.intel.com>
Subject: Re: [PATCH] platform/x86/intel/pmc: Fix ioremap of bad address

On Mon, 06 Jan 2025 09:46:52 -0800, David E. Box wrote:

> In pmc_core_ssram_get_pmc(), the physical addresses for hidden SSRAM
> devices are retrieved from the MMIO region of the primary SSRAM device. If
> additional devices are not present, the address returned is zero.
> Currently, the code does not check for this condition, resulting in ioremap
> incorrectly attempting to map address 0. Add a check for a zero address and
> return 0 if no additional devices are found, as it is not an error for the
> device to be absent.
> 
> [...]

Thank you for your contribution, it has been applied to my local
review-ilpo-fixes branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-fixes branch only once I've pushed my
local branch there, which might take a while.

The list of commits applied:
[1/1] platform/x86/intel/pmc: Fix ioremap of bad address
      commit: 1d7461d0c8330689117286169106af6531a747ed

--
 i.