linux-kernel - Re: [PATCH 0/6] platform/x86: firmware_attributes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <3f3ca62d-cd30-4d1a-81c6-e2eb47b0787e@app.fastmail.com>
Date: Mon, 06 Jan 2025 21:53:47 -0500
From: "Mark Pearson" <mpearson-lenovo@...ebb.ca>
To: Thomas Weißschuh <linux@...ssschuh.net>,
 "Hans de Goede" <hdegoede@...hat.com>,
 Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
 "Mark Pearson" <markpearson@...ovo.com>, "Jorge Lopez" <jorge.lopez2@...com>,
 "Prasanth Ksr" <prasanth.ksr@...l.com>
Cc: "Joshua Grisham" <josh@...huagrisham.com>,
 "platform-driver-x86@...r.kernel.org" <platform-driver-x86@...r.kernel.org>,
 linux-kernel@...r.kernel.org, Dell.Client.Kernel@...l.com
Subject: Re: [PATCH 0/6] platform/x86: firmware_attributes_class: Simplify API

Hi Thomas,

On Fri, Jan 3, 2025, at 6:05 PM, Thomas Weißschuh wrote:
> Looking at the users of firmware_attributes_class makes my head hurt.
> Simplify the subsystem and its users.
>
> This will break the currently developed samsung-galaxybook driver,
> resolving the breakage should be trivial.
>
> Only compile-tested.
>
> I have some further improvements in the pipeline building on these
> changes, but those will need some more time.
>
> Signed-off-by: Thomas Weißschuh <linux@...ssschuh.net>
> ---
> Thomas Weißschuh (6):
>       platform/x86: firmware_attributes_class: Move include linux/device/class.h
>       platform/x86: firmware_attributes_class: Simplify API
>       platform/x86: think-lmi: Directly use firmware_attributes_class
>       platform/x86: hp-bioscfg: Directly use firmware_attributes_class
>       platform/x86: dell-sysman: Directly use firmware_attributes_class
>       platform/x86: firmware_attributes_class: Drop lifecycle functions
>
>  drivers/platform/x86/dell/dell-wmi-sysman/sysman.c | 17 +++------
>  drivers/platform/x86/firmware_attributes_class.c   | 42 +++++-----------------
>  drivers/platform/x86/firmware_attributes_class.h   |  5 +--
>  drivers/platform/x86/hp/hp-bioscfg/bioscfg.c       | 14 ++------
>  drivers/platform/x86/think-lmi.c                   | 13 ++-----
>  5 files changed, 21 insertions(+), 70 deletions(-)
> ---
> base-commit: 0bc21e701a6ffacfdde7f04f87d664d82e8a13bf
> change-id: 20250103-firmware-attributes-simplify-9ae561459260
>
> Best regards,
> -- 
> Thomas Weißschuh <linux@...ssschuh.net>

For the series - looks good to me. Tested on X1 Carbon G12 and confirmed think-lmi is working as expected.
Reviewed-by: Mark Pearson <mpearson-lenovo@...ebb.ca>
Tested-by: Mark Pearson <mpearson-lenovo@...ebb.ca>

Mark