linux-kernel - Re: [PATCH 2/2] hwmon: Add driver for TI INA233 Current and Power Monitor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202501080011.H8YAGThn-lkp@intel.com>
Date: Wed, 8 Jan 2025 01:08:09 +0800
From: kernel test robot <lkp@...el.com>
To: Leo Yang <leo.yang.sy0@...il.com>, jdelvare@...e.com,
	linux@...ck-us.net, robh@...nel.org, krzk+dt@...nel.org,
	conor+dt@...nel.org, Leo-Yang@...ntatw.com, corbet@....net,
	Delphine_CC_Chiu@...ynn.com, linux-hwmon@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-doc@...r.kernel.org
Cc: oe-kbuild-all@...ts.linux.dev
Subject: Re: [PATCH 2/2] hwmon: Add driver for TI INA233 Current and Power
 Monitor

Hi Leo,

kernel test robot noticed the following build warnings:

[auto build test WARNING on groeck-staging/hwmon-next]
[also build test WARNING on linus/master v6.13-rc6 next-20250107]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Leo-Yang/dt-bindings-Add-INA233-device/20250106-151934
base:   https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon-next
patch link:    https://lore.kernel.org/r/20250106071337.3017926-3-Leo-Yang%40quantatw.com
patch subject: [PATCH 2/2] hwmon: Add driver for TI INA233 Current and Power Monitor
config: csky-randconfig-r131-20250107 (https://download.01.org/0day-ci/archive/20250108/202501080011.H8YAGThn-lkp@intel.com/config)
compiler: csky-linux-gcc (GCC) 14.2.0
reproduce: (https://download.01.org/0day-ci/archive/20250108/202501080011.H8YAGThn-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202501080011.H8YAGThn-lkp@intel.com/

sparse warnings: (new ones prefixed by >>)
>> drivers/hwmon/pmbus/ina233.c:93:26: sparse: sparse: symbol 'ina233_info' was not declared. Should it be static?

vim +/ina233_info +93 drivers/hwmon/pmbus/ina233.c

    92	
  > 93	struct pmbus_driver_info ina233_info = {
    94		.pages = 1,
    95		.format[PSC_VOLTAGE_IN] = direct,
    96		.format[PSC_VOLTAGE_OUT] = direct,
    97		.format[PSC_CURRENT_OUT] = direct,
    98		.format[PSC_POWER] = direct,
    99		.func[0] = PMBUS_HAVE_VIN | PMBUS_HAVE_VOUT | PMBUS_HAVE_STATUS_INPUT
   100			| PMBUS_HAVE_IOUT | PMBUS_HAVE_STATUS_IOUT
   101			| PMBUS_HAVE_POUT
   102			| PMBUS_HAVE_VMON | PMBUS_HAVE_STATUS_VMON,
   103		.m[PSC_VOLTAGE_IN] = 8,
   104		.R[PSC_VOLTAGE_IN] = 2,
   105		.m[PSC_VOLTAGE_OUT] = 8,
   106		.R[PSC_VOLTAGE_OUT] = 2,
   107		.read_word_data = ina233_read_word_data,
   108	};
   109	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki