linux-kernel - drivers/iommu/amd/iommu.c:1269 domain_flush_complete() warn: inconsistent indenting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <202501080139.yHwH0ePx-lkp@intel.com>
Date: Wed, 8 Jan 2025 01:50:55 +0800
From: kernel test robot <lkp@...el.com>
To: Vasant Hegde <vasant.hegde@....com>
Cc: oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
	Joerg Roedel <jroedel@...e.de>, Jason Gunthorpe <jgg@...dia.com>
Subject: drivers/iommu/amd/iommu.c:1269 domain_flush_complete() warn:
 inconsistent indenting

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   fbfd64d25c7af3b8695201ebc85efe90be28c5a3
commit: d16041124de1dea4389b5e6b330657f34f8c0492 iommu/amd: xarray to track protection_domain->iommu list
date:   10 weeks ago
config: x86_64-defconfig (https://download.01.org/0day-ci/archive/20250108/202501080139.yHwH0ePx-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202501080139.yHwH0ePx-lkp@intel.com/

New smatch warnings:
drivers/iommu/amd/iommu.c:1269 domain_flush_complete() warn: inconsistent indenting

Old smatch warnings:
drivers/iommu/amd/iommu.c:1269 domain_flush_complete() warn: iterator 'i' not incremented
drivers/iommu/amd/iommu.c:1462 domain_flush_pages_v1() warn: iterator 'i' not incremented
drivers/iommu/amd/iommu.c:1996 init_gcr3_table() warn: missing error code? 'ret'

vim +1269 drivers/iommu/amd/iommu.c

  1257	
  1258	static void domain_flush_complete(struct protection_domain *domain)
  1259	{
  1260		struct pdom_iommu_info *pdom_iommu_info;
  1261		unsigned long i;
  1262	
  1263		lockdep_assert_held(&domain->lock);
  1264	
  1265		/*
  1266		 * Devices of this domain are behind this IOMMU
  1267		 * We need to wait for completion of all commands.
  1268		 */
> 1269		 xa_for_each(&domain->iommu_array, i, pdom_iommu_info)
  1270			iommu_completion_wait(pdom_iommu_info->iommu);
  1271	}
  1272	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki