linux-kernel - Re: [PATCH] ACPI: tables: Use string choice helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0iEmYTKJ-nB+vgew5PoSYTrvc3D2tX++SLP80pxk0entg@mail.gmail.com>
Date: Tue, 7 Jan 2025 19:14:52 +0100
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: Sunil V L <sunilvl@...tanamicro.com>
Cc: linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org, 
	"Rafael J . Wysocki" <rafael@...nel.org>, Len Brown <lenb@...nel.org>, 
	Palmer Dabbelt <palmer@...osinc.com>, Andrew Jones <ajones@...tanamicro.com>, 
	Conor Dooley <conor.dooley@...rochip.com>, Anup Patel <apatel@...tanamicro.com>, 
	kernel test robot <lkp@...el.com>, Julia Lawall <julia.lawall@...ia.fr>
Subject: Re: [PATCH] ACPI: tables: Use string choice helpers

On Fri, Jan 3, 2025 at 4:51 AM Sunil V L <sunilvl@...tanamicro.com> wrote:
>
> Use str_enabled_disabled string helpers for better readability and to
> fix cocci warning.
>
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/r/202501010947.0e3GVHNa-lkp@intel.com/
> Reported-by: Julia Lawall <julia.lawall@...ia.fr>
> Closes: https://lore.kernel.org/r/202501010947.0e3GVHNa-lkp@intel.com/
> Signed-off-by: Sunil V L <sunilvl@...tanamicro.com>
> ---
>  drivers/acpi/tables.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/acpi/tables.c b/drivers/acpi/tables.c
> index 9e1b01c35070..2295abbecd14 100644
> --- a/drivers/acpi/tables.c
> +++ b/drivers/acpi/tables.c
> @@ -56,7 +56,7 @@ void acpi_table_print_madt_entry(struct acpi_subtable_header *header)
>                             (struct acpi_madt_local_apic *)header;
>                         pr_debug("LAPIC (acpi_id[0x%02x] lapic_id[0x%02x] %s)\n",
>                                  p->processor_id, p->id,
> -                                (p->lapic_flags & ACPI_MADT_ENABLED) ? "enabled" : "disabled");
> +                                str_enabled_disabled(p->lapic_flags & ACPI_MADT_ENABLED));
>                 }
>                 break;
>
> @@ -66,7 +66,7 @@ void acpi_table_print_madt_entry(struct acpi_subtable_header *header)
>                             (struct acpi_madt_local_x2apic *)header;
>                         pr_debug("X2APIC (apic_id[0x%02x] uid[0x%02x] %s)\n",
>                                  p->local_apic_id, p->uid,
> -                                (p->lapic_flags & ACPI_MADT_ENABLED) ? "enabled" : "disabled");
> +                                str_enabled_disabled(p->lapic_flags & ACPI_MADT_ENABLED));
>                 }
>                 break;
>
> @@ -160,7 +160,7 @@ void acpi_table_print_madt_entry(struct acpi_subtable_header *header)
>                             (struct acpi_madt_local_sapic *)header;
>                         pr_debug("LSAPIC (acpi_id[0x%02x] lsapic_id[0x%02x] lsapic_eid[0x%02x] %s)\n",
>                                  p->processor_id, p->id, p->eid,
> -                                (p->lapic_flags & ACPI_MADT_ENABLED) ? "enabled" : "disabled");
> +                                str_enabled_disabled(p->lapic_flags & ACPI_MADT_ENABLED));
>                 }
>                 break;
>
> @@ -183,7 +183,7 @@ void acpi_table_print_madt_entry(struct acpi_subtable_header *header)
>                         pr_debug("GICC (acpi_id[0x%04x] address[%llx] MPIDR[0x%llx] %s)\n",
>                                  p->uid, p->base_address,
>                                  p->arm_mpidr,
> -                                (p->flags & ACPI_MADT_ENABLED) ? "enabled" : "disabled");
> +                                str_enabled_disabled(p->flags & ACPI_MADT_ENABLED));
>
>                 }
>                 break;
> @@ -218,7 +218,7 @@ void acpi_table_print_madt_entry(struct acpi_subtable_header *header)
>
>                         pr_debug("CORE PIC (processor_id[0x%02x] core_id[0x%02x] %s)\n",
>                                  p->processor_id, p->core_id,
> -                                (p->flags & ACPI_MADT_ENABLED) ? "enabled" : "disabled");
> +                                str_enabled_disabled(p->flags & ACPI_MADT_ENABLED));
>                 }
>                 break;
>
> @@ -228,7 +228,7 @@ void acpi_table_print_madt_entry(struct acpi_subtable_header *header)
>
>                         pr_debug("RISC-V INTC (acpi_uid[0x%04x] hart_id[0x%llx] %s)\n",
>                                  p->uid, p->hart_id,
> -                                (p->flags & ACPI_MADT_ENABLED) ? "enabled" : "disabled");
> +                                str_enabled_disabled(p->flags & ACPI_MADT_ENABLED));
>                 }
>                 break;
>
> --

Applied as 6.14 material, thanks!