linux-kernel - Re: [PATCH] pm: cpupower: Makefile: Fix cross compilation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3b55d23b-aa37-4187-9649-aef663ee1de8@broadcom.com>
Date: Tue, 7 Jan 2025 10:56:19 -0800
From: Florian Fainelli <florian.fainelli@...adcom.com>
To: Shuah Khan <skhan@...uxfoundation.org>,
 "Peng Fan (OSS)" <peng.fan@....nxp.com>, Thomas Renninger <trenn@...e.com>,
 Shuah Khan <shuah@...nel.org>, "John B. Wyatt IV" <jwyatt@...hat.com>,
 John Kacur <jkacur@...hat.com>, Peng Fan <peng.fan@....com>,
 "open list:CPU POWER MONITORING SUBSYSTEM" <linux-pm@...r.kernel.org>,
 open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] pm: cpupower: Makefile: Fix cross compilation

On 12/9/24 16:58, Shuah Khan wrote:
> On 12/2/24 10:12, Florian Fainelli wrote:
>> On 11/28/24 17:20, Peng Fan (OSS) wrote:
>>> From: Peng Fan <peng.fan@....com>
>>>
>>> After commit f79473ed9220 ("pm: cpupower: Makefile: Allow overriding
>>> cross-compiling env params") we would fail to cross compile cpupower in
>>> buildroot which uses the recipe at [1] where only the CROSS variable is
>>> being set.
>>>
>>> The issue here is the use of the lazy evaluation for all variables: CC,
>>> LD, AR, STRIP, RANLIB, rather than just CROSS.
>>>
>>> [1]:
>>> https://git.buildroot.net/buildroot/tree/package/linux-tools/linux- 
>>> tool-cpupower.mk.in
>>>
>>> Fixes: f79473ed9220 ("pm: cpupower: Makefile: Allow overriding cross- 
>>> compiling env params")
>>> Reported-by: Florian Fainelli <florian.fainelli@...adcom.com>
>>> Closes: https://lore.kernel.org/all/2bbabd2c-24ef-493c- 
>>> a199-594e5dada3da@...adcom.com/
>>> Signed-off-by: Peng Fan <peng.fan@....com>
>>
>> Tested-by: Florian Fainelli <florian.fainelli@...adcom.com>
>>
>> Thanks!
> 
> Thank you. Applied to linux-cpupower for my next full request to
> Rafael.

Since this is a bug fix, any chance you can fast track that change so we 
can keep on building that tool in various environments?

Thanks
-- 
Florian