linux-kernel - Re: [PATCH] i2c: amd756: Fix endianness handling for word data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ovddzx2zitp6lqjdasinn2zaaefp35y4mspol3v3x5rk3tddgo@kgcwexuai2ir>
Date: Tue, 7 Jan 2025 19:57:55 +0100
From: Andi Shyti <andi.shyti@...nel.org>
To: Wolfram Sang <wsa+renesas@...g-engineering.com>, 
	Atharva Tiwari <evepolonium@...il.com>, kernel test robot <lkp@...el.com>, 
	Jean Delvare <jdelvare@...e.com>, linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] i2c: amd756: Fix endianness handling for word data

On Sat, Jan 04, 2025 at 11:32:59AM +0100, Wolfram Sang wrote:
> > Yeah! That was my first thought, but because this was reported
> > by LKP (which I respect more than other code analyzers) as a
> > potential issue, I was on the 50-50.
> 
> A potential issue on outdated hardware (or better: non-existing versions
> of outdated harware) which has not showed up since the git era is not
> really a for-current bugfix in my book. That being said, it does not
> harm in for-current.

Honestly, I'm not entirely happy with this patch. It seems to add
unnecessary churn without addressing an actual need. Since we're
operating in the same endianness domain, I don't think there is
requirement for an endianness conversion here.

On one hand, I want to give credit to Atharva for his effort; on
the other hand, I think the real solution would be to just remove
the comments altogether.

I'm going to hold off for now and wait for additional feedback.
If no further comments come in, I'll likely drop this patch.

Andi