linux-kernel - Re: [PATCH] nfs: Make NFS_FSCACHE select NETFS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ba8defca2f731d588a94e5e7013c1c19@manjaro.org>
Date: Tue, 07 Jan 2025 20:21:34 +0100
From: Dragan Simic <dsimic@...jaro.org>
To: trondmy@...nel.org, anna@...nel.org
Cc: linux-nfs@...r.kernel.org, linux-kernel@...r.kernel.org,
 stable@...r.kernel.org, Diederik de Haas <didi.debian@...ow.org>
Subject: Re: [PATCH] nfs: Make NFS_FSCACHE select NETFS_SUPPORT instead of
 depending on it

Hello,

On 2024-12-27 20:17, Dragan Simic wrote:
> Having the NFS_FSCACHE option depend on the NETFS_SUPPORT options makes
> selecting NFS_FSCACHE impossible unless another option that 
> additionally
> selects NETFS_SUPPORT is already selected.
> 
> As a result, for example, being able to reach and select the 
> NFS_FSCACHE
> option requires the CEPH_FS or CIFS option to be selected beforehand, 
> which
> obviously doesn't make much sense.
> 
> Let's correct this by making the NFS_FSCACHE option actually select the
> NETFS_SUPPORT option, instead of depending on it.
> 
> Fixes: 915cd30cdea8 ("netfs, fscache: Combine fscache with netfs")
> Cc: stable@...r.kernel.org
> Reported-by: Diederik de Haas <didi.debian@...ow.org>
> Signed-off-by: Dragan Simic <dsimic@...jaro.org>

Just checking, any thoughts about this patch?

> ---
>  fs/nfs/Kconfig | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/fs/nfs/Kconfig b/fs/nfs/Kconfig
> index 0eb20012792f..d3f76101ad4b 100644
> --- a/fs/nfs/Kconfig
> +++ b/fs/nfs/Kconfig
> @@ -170,7 +170,8 @@ config ROOT_NFS
> 
>  config NFS_FSCACHE
>  	bool "Provide NFS client caching support"
> -	depends on NFS_FS=m && NETFS_SUPPORT || NFS_FS=y && NETFS_SUPPORT=y
> +	depends on NFS_FS
> +	select NETFS_SUPPORT
>  	select FSCACHE
>  	help
>  	  Say Y here if you want NFS data to be cached locally on disc 
> through