linux-kernel - Re: [PATCH v3] spmi: hisi-spmi-controller: manage the OF node reference in device initialization and cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <197c4149efbfa24dee4711923cbddff4.sboyd@kernel.org>
Date: Tue, 07 Jan 2025 11:49:21 -0800
From: Stephen Boyd <sboyd@...nel.org>
To: Joe Hattori <joe@...is.s.u-tokyo.ac.jp>, mchehab+huawei@...nel.org
Cc: linux-kernel@...r.kernel.org, krzk@...nel.org, Joe Hattori <joe@...is.s.u-tokyo.ac.jp>
Subject: Re: [PATCH v3] spmi: hisi-spmi-controller: manage the OF node reference in device initialization and cleanup

Quoting Joe Hattori (2024-12-18 17:35:07)
> spmi_controller_probe() increments the refcount of an OF node, but does
> not release it. Instead, call of_node_get() in spmi_controller_alloc()
> and release it in spmi_ctrl_release() to avoid the reference leak. Also
> remove the lines in spmi_pmic_arb_bus_init() and spmi_controller_probe()
> where a pdev's of_node is stored after spmi_controller_alloc() is
> called, since the node is already set with an incremented refcount in
> spmi_controller_alloc(). Those lines do not overwrite the of_node since
> they set the same node that the spmi_controller_alloc() does, but are
> confusing at the very least.
> 
> This bug was found by an experimental verification tool that I am
> developing.
> 
> Fixes: e562cf3aea3e ("spmi: hisi-spmi-controller: move driver from staging")
> Signed-off-by: Joe Hattori <joe@...is.s.u-tokyo.ac.jp>
> ---

Applied to spmi-next