| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202501080538.nx0eXGFn-lkp@intel.com>
Date: Wed, 8 Jan 2025 05:14:12 +0800
From: kernel test robot <lkp@...el.com>
To: Sam Bobroff <sbobroff@...ux.ibm.com>
Cc: oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
Michael Ellerman <mpe@...erman.id.au>
Subject: arch/powerpc/kernel/eeh_pe.c:670: warning: Function parameter or
struct member 'root' not described in 'eeh_pe_state_clear'
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: fbfd64d25c7af3b8695201ebc85efe90be28c5a3
commit: 9ed5ca66aa66e5ce2e1d8758250a4d740052c8cd powerpc/eeh: Add include_passed to eeh_pe_state_clear()
date: 6 years ago
config: powerpc64-randconfig-002-20231105 (https://download.01.org/0day-ci/archive/20250108/202501080538.nx0eXGFn-lkp@intel.com/config)
compiler: powerpc64-linux-gcc (GCC) 12.4.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250108/202501080538.nx0eXGFn-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202501080538.nx0eXGFn-lkp@intel.com/
All warnings (new ones prefixed by >>):
arch/powerpc/kernel/eeh_pe.c:282: warning: cannot understand function prototype: 'struct eeh_pe_get_flag '
arch/powerpc/kernel/eeh_pe.c:602: warning: Function parameter or struct member 'root' not described in 'eeh_pe_state_mark'
arch/powerpc/kernel/eeh_pe.c:602: warning: Function parameter or struct member 'state' not described in 'eeh_pe_state_mark'
arch/powerpc/kernel/eeh_pe.c:602: warning: Excess function parameter 'pe' description in 'eeh_pe_state_mark'
arch/powerpc/kernel/eeh_pe.c:620: warning: Function parameter or struct member 'root' not described in 'eeh_pe_mark_isolated'
arch/powerpc/kernel/eeh_pe.c:620: warning: Excess function parameter 'pe' description in 'eeh_pe_mark_isolated'
arch/powerpc/kernel/eeh_pe.c:655: warning: Function parameter or struct member 'mode' not described in 'eeh_pe_dev_mode_mark'
arch/powerpc/kernel/eeh_pe.c:655: warning: expecting prototype for eeh_pe_dev_state_mark(). Prototype was for eeh_pe_dev_mode_mark() instead
>> arch/powerpc/kernel/eeh_pe.c:670: warning: Function parameter or struct member 'root' not described in 'eeh_pe_state_clear'
>> arch/powerpc/kernel/eeh_pe.c:670: warning: Excess function parameter 'data' description in 'eeh_pe_state_clear'
arch/powerpc/kernel/eeh_pe.c:869: warning: Function parameter or struct member 'edev' not described in 'eeh_restore_one_device_bars'
arch/powerpc/kernel/eeh_pe.c:869: warning: Excess function parameter 'data' description in 'eeh_restore_one_device_bars'
vim +670 arch/powerpc/kernel/eeh_pe.c
d2b0f6f77ee525 arch/powerpc/kernel/eeh_pe.c Gavin Shan 2014-04-24 658
5b6635294418a9 arch/powerpc/platforms/pseries/eeh_pe.c Gavin Shan 2012-09-07 659 /**
9ed5ca66aa66e5 arch/powerpc/kernel/eeh_pe.c Sam Bobroff 2018-11-29 660 * eeh_pe_state_clear - Clear state for the PE
5b6635294418a9 arch/powerpc/platforms/pseries/eeh_pe.c Gavin Shan 2012-09-07 661 * @data: EEH PE
9ed5ca66aa66e5 arch/powerpc/kernel/eeh_pe.c Sam Bobroff 2018-11-29 662 * @state: state
9ed5ca66aa66e5 arch/powerpc/kernel/eeh_pe.c Sam Bobroff 2018-11-29 663 * @include_passed: include passed-through devices?
5b6635294418a9 arch/powerpc/platforms/pseries/eeh_pe.c Gavin Shan 2012-09-07 664 *
5b6635294418a9 arch/powerpc/platforms/pseries/eeh_pe.c Gavin Shan 2012-09-07 665 * The function is used to clear the indicated state from the
5b6635294418a9 arch/powerpc/platforms/pseries/eeh_pe.c Gavin Shan 2012-09-07 666 * given PE. Besides, we also clear the check count of the PE
5b6635294418a9 arch/powerpc/platforms/pseries/eeh_pe.c Gavin Shan 2012-09-07 667 * as well.
5b6635294418a9 arch/powerpc/platforms/pseries/eeh_pe.c Gavin Shan 2012-09-07 668 */
9ed5ca66aa66e5 arch/powerpc/kernel/eeh_pe.c Sam Bobroff 2018-11-29 669 void eeh_pe_state_clear(struct eeh_pe *root, int state, bool include_passed)
5b6635294418a9 arch/powerpc/platforms/pseries/eeh_pe.c Gavin Shan 2012-09-07 @670 {
9ed5ca66aa66e5 arch/powerpc/kernel/eeh_pe.c Sam Bobroff 2018-11-29 671 struct eeh_pe *pe;
22fca179240941 arch/powerpc/kernel/eeh_pe.c Gavin Shan 2014-09-30 672 struct eeh_dev *edev, *tmp;
22fca179240941 arch/powerpc/kernel/eeh_pe.c Gavin Shan 2014-09-30 673 struct pci_dev *pdev;
5b6635294418a9 arch/powerpc/platforms/pseries/eeh_pe.c Gavin Shan 2012-09-07 674
9ed5ca66aa66e5 arch/powerpc/kernel/eeh_pe.c Sam Bobroff 2018-11-29 675 eeh_for_each_pe(root, pe) {
d2b0f6f77ee525 arch/powerpc/kernel/eeh_pe.c Gavin Shan 2014-04-24 676 /* Keep the state of permanently removed PE intact */
432227e9077eec arch/powerpc/kernel/eeh_pe.c Gavin Shan 2014-12-11 677 if (pe->state & EEH_PE_REMOVED)
9ed5ca66aa66e5 arch/powerpc/kernel/eeh_pe.c Sam Bobroff 2018-11-29 678 continue;
9ed5ca66aa66e5 arch/powerpc/kernel/eeh_pe.c Sam Bobroff 2018-11-29 679
9ed5ca66aa66e5 arch/powerpc/kernel/eeh_pe.c Sam Bobroff 2018-11-29 680 if (!include_passed && eeh_pe_passed(pe))
9ed5ca66aa66e5 arch/powerpc/kernel/eeh_pe.c Sam Bobroff 2018-11-29 681 continue;
d2b0f6f77ee525 arch/powerpc/kernel/eeh_pe.c Gavin Shan 2014-04-24 682
5b6635294418a9 arch/powerpc/platforms/pseries/eeh_pe.c Gavin Shan 2012-09-07 683 pe->state &= ~state;
d2b0f6f77ee525 arch/powerpc/kernel/eeh_pe.c Gavin Shan 2014-04-24 684
22fca179240941 arch/powerpc/kernel/eeh_pe.c Gavin Shan 2014-09-30 685 /*
22fca179240941 arch/powerpc/kernel/eeh_pe.c Gavin Shan 2014-09-30 686 * Special treatment on clearing isolated state. Clear
22fca179240941 arch/powerpc/kernel/eeh_pe.c Gavin Shan 2014-09-30 687 * check count since last isolation and put all affected
22fca179240941 arch/powerpc/kernel/eeh_pe.c Gavin Shan 2014-09-30 688 * devices to normal state.
22fca179240941 arch/powerpc/kernel/eeh_pe.c Gavin Shan 2014-09-30 689 */
22fca179240941 arch/powerpc/kernel/eeh_pe.c Gavin Shan 2014-09-30 690 if (!(state & EEH_PE_ISOLATED))
9ed5ca66aa66e5 arch/powerpc/kernel/eeh_pe.c Sam Bobroff 2018-11-29 691 continue;
22fca179240941 arch/powerpc/kernel/eeh_pe.c Gavin Shan 2014-09-30 692
5b6635294418a9 arch/powerpc/platforms/pseries/eeh_pe.c Gavin Shan 2012-09-07 693 pe->check_count = 0;
22fca179240941 arch/powerpc/kernel/eeh_pe.c Gavin Shan 2014-09-30 694 eeh_pe_for_each_dev(pe, edev, tmp) {
22fca179240941 arch/powerpc/kernel/eeh_pe.c Gavin Shan 2014-09-30 695 pdev = eeh_dev_to_pci_dev(edev);
22fca179240941 arch/powerpc/kernel/eeh_pe.c Gavin Shan 2014-09-30 696 if (!pdev)
22fca179240941 arch/powerpc/kernel/eeh_pe.c Gavin Shan 2014-09-30 697 continue;
22fca179240941 arch/powerpc/kernel/eeh_pe.c Gavin Shan 2014-09-30 698
22fca179240941 arch/powerpc/kernel/eeh_pe.c Gavin Shan 2014-09-30 699 pdev->error_state = pci_channel_io_normal;
22fca179240941 arch/powerpc/kernel/eeh_pe.c Gavin Shan 2014-09-30 700 }
5b6635294418a9 arch/powerpc/platforms/pseries/eeh_pe.c Gavin Shan 2012-09-07 701
b6541db1395298 arch/powerpc/kernel/eeh_pe.c Gavin Shan 2014-10-01 702 /* Unblock PCI config access if required */
b6541db1395298 arch/powerpc/kernel/eeh_pe.c Gavin Shan 2014-10-01 703 if (pe->state & EEH_PE_CFG_RESTRICTED)
b6541db1395298 arch/powerpc/kernel/eeh_pe.c Gavin Shan 2014-10-01 704 pe->state &= ~EEH_PE_CFG_BLOCKED;
5b6635294418a9 arch/powerpc/platforms/pseries/eeh_pe.c Gavin Shan 2012-09-07 705 }
39bfd715b48374 arch/powerpc/kernel/eeh_pe.c Gavin Shan 2015-07-30 706 }
39bfd715b48374 arch/powerpc/kernel/eeh_pe.c Gavin Shan 2015-07-30 707
:::::: The code at line 670 was first introduced by commit
:::::: 5b6635294418a954b5f911375b86d3552cf93f36 powerpc/eeh: Trace EEH state based on PE
:::::: TO: Gavin Shan <shangw@...ux.vnet.ibm.com>
:::::: CC: Benjamin Herrenschmidt <benh@...nel.crashing.org>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists