| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAP-5=fVQZ0nQhOPsA9oGtTZQwMYY2o7t-6xuNL+Qp+TfVYKSPQ@mail.gmail.com>
Date: Tue, 7 Jan 2025 14:28:06 -0800
From: Ian Rogers <irogers@...gle.com>
To: Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>,
Arnaldo Carvalho de Melo <acme@...nel.org>, Namhyung Kim <namhyung@...nel.org>,
Mark Rutland <mark.rutland@....com>,
Alexander Shishkin <alexander.shishkin@...ux.intel.com>, Jiri Olsa <jolsa@...nel.org>,
Ian Rogers <irogers@...gle.com>, Adrian Hunter <adrian.hunter@...el.com>,
Kan Liang <kan.liang@...ux.intel.com>, Thomas Richter <tmricht@...ux.ibm.com>,
James Clark <james.clark@...aro.org>, linux-perf-users@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/2] perf check: Add sanitizer features
On Tue, Oct 22, 2024 at 10:48 AM Ian Rogers <irogers@...gle.com> wrote:
>
> Sanitizer builds can break expectations for test disassembly,
> particularly in the annotate test. Add features for the different
> sanitizer options seen in the source tree.
>
> An example for an asan build:
> ```
> $ perf version --build-options
> perf version 6.12.rc3.g939b0caafd01
> aio: [ on ] # HAVE_AIO_SUPPORT
> bpf: [ on ] # HAVE_LIBBPF_SUPPORT
> bpf_skeletons: [ on ] # HAVE_BPF_SKEL
> debuginfod: [ on ] # HAVE_DEBUGINFOD_SUPPORT
> dwarf: [ on ] # HAVE_DWARF_SUPPORT
> dwarf_getlocations: [ on ] # HAVE_DWARF_GETLOCATIONS_SUPPORT
> dwarf-unwind: [ on ] # HAVE_DWARF_UNWIND_SUPPORT
> auxtrace: [ on ] # HAVE_AUXTRACE_SUPPORT
> libaudit: [ OFF ] # HAVE_LIBAUDIT_SUPPORT
> libbfd: [ OFF ] # HAVE_LIBBFD_SUPPORT
> libcapstone: [ on ] # HAVE_LIBCAPSTONE_SUPPORT
> libcrypto: [ on ] # HAVE_LIBCRYPTO_SUPPORT
> libdw-dwarf-unwind: [ on ] # HAVE_DWARF_SUPPORT
> libelf: [ on ] # HAVE_LIBELF_SUPPORT
> libnuma: [ OFF ] # HAVE_LIBNUMA_SUPPORT
> libopencsd: [ OFF ] # HAVE_CSTRACE_SUPPORT
> libperl: [ on ] # HAVE_LIBPERL_SUPPORT
> libpfm4: [ on ] # HAVE_LIBPFM
> libpython: [ on ] # HAVE_LIBPYTHON_SUPPORT
> libslang: [ on ] # HAVE_SLANG_SUPPORT
> libtraceevent: [ on ] # HAVE_LIBTRACEEVENT
> libunwind: [ on ] # HAVE_LIBUNWIND_SUPPORT
> lzma: [ on ] # HAVE_LZMA_SUPPORT
> numa_num_possible_cpus: [ OFF ] # HAVE_LIBNUMA_SUPPORT
> sanitizer: [ on ] # HAVE_SANITIZER
> sanitizer_address: [ on ] # HAVE_SANITIZER_ADDRESS
> sanitizer_leak: [ on ] # HAVE_SANITIZER_LEAK
> sanitizer_memory: [ OFF ] # HAVE_SANITIZER_MEMORY
> sanitizer_thread: [ OFF ] # HAVE_SANITIZER_THREAD
> sanitizer_undefined: [ OFF ] # HAVE_SANITIZER_UNDEFINED
> syscall_table: [ on ] # HAVE_SYSCALL_TABLE_SUPPORT
> zlib: [ on ] # HAVE_ZLIB_SUPPORT
> zstd: [ on ] # HAVE_ZSTD_SUPPORT
> ```
>
> Signed-off-by: Ian Rogers <irogers@...gle.com>
> ---
> v3 split out annotate test check
> v2 build fix.
Working around the asan issue for the annotate test is no longer
needed for me. Should we carry this first patch so that tests can have
better feature checks on sanitizers? I can resend the patch again on
its own, if this is useful.
Thanks,
Ian
> ---
> tools/perf/builtin-check.c | 49 ++++++++++++++++++++++++++++++++++++++
> 1 file changed, 49 insertions(+)
>
> diff --git a/tools/perf/builtin-check.c b/tools/perf/builtin-check.c
> index 0b76b6e42b78..c44444008d64 100644
> --- a/tools/perf/builtin-check.c
> +++ b/tools/perf/builtin-check.c
> @@ -9,6 +9,49 @@
> #include <string.h>
> #include <subcmd/parse-options.h>
>
> +#if defined(__has_feature)
> +#define HAS_COMPILER_FEATURE(feature) __has_feature(feature)
> +#else
> +#define HAS_COMPILER_FEATURE(feature) 0
> +#endif
> +
> +#if defined(__SANITIZE_ADDRESS__) || defined(ADDRESS_SANITIZER) || \
> + HAS_COMPILER_FEATURE(address_sanitizer)
> +#define HAVE_SANITIZER_ADDRESS 1
> +#define HAVE_SANITIZER_LEAK 1
> +#elif defined(LEAK_SANITIZER) || HAS_COMPILER_FEATURE(leak_sanitizer)
> +#define HAVE_SANITIZER_ADDRESS 0
> +#define HAVE_SANITIZER_LEAK 1
> +#else
> +#define HAVE_SANITIZER_ADDRESS 0
> +#define HAVE_SANITIZER_LEAK 0
> +#endif
> +
> +#if defined(MEMORY_SANITIZER) || HAS_COMPILER_FEATURE(memory_sanitizer)
> +#define HAVE_SANITIZER_MEMORY 1
> +#else
> +#define HAVE_SANITIZER_MEMORY 0
> +#endif
> +
> +#if defined(THREAD_SANITIZER) || HAS_COMPILER_FEATURE(thread_sanitizer)
> +#define HAVE_SANITIZER_THREAD 1
> +#else
> +#define HAVE_SANITIZER_THREAD 0
> +#endif
> +
> +#if defined(UNDEFINED_SANITIZER) || HAS_COMPILER_FEATURE(undefined_sanitizer)
> +#define HAVE_SANITIZER_UNDEFINED 1
> +#else
> +#define HAVE_SANITIZER_UNDEFINED 0
> +#endif
> +
> +#if HAVE_SANITIZER_ADDRESS || HAVE_SANITIZER_LEAK || HAVE_SANITIZER_MEMORY || \
> + HAVE_SANITIZER_THREAD || HAVE_SANITIZER_UNDEFINED
> +#define HAVE_SANITIZER 1
> +#else
> +#define HAVE_SANITIZER 0
> +#endif
> +
> static const char * const check_subcommands[] = { "feature", NULL };
> static struct option check_options[] = {
> OPT_BOOLEAN('q', "quiet", &quiet, "do not show any warnings or messages"),
> @@ -47,6 +90,12 @@ struct feature_status supported_features[] = {
> FEATURE_STATUS("libunwind", HAVE_LIBUNWIND_SUPPORT),
> FEATURE_STATUS("lzma", HAVE_LZMA_SUPPORT),
> FEATURE_STATUS("numa_num_possible_cpus", HAVE_LIBNUMA_SUPPORT),
> + FEATURE_STATUS("sanitizer", HAVE_SANITIZER),
> + FEATURE_STATUS("sanitizer_address", HAVE_SANITIZER_ADDRESS),
> + FEATURE_STATUS("sanitizer_leak", HAVE_SANITIZER_LEAK),
> + FEATURE_STATUS("sanitizer_memory", HAVE_SANITIZER_MEMORY),
> + FEATURE_STATUS("sanitizer_thread", HAVE_SANITIZER_THREAD),
> + FEATURE_STATUS("sanitizer_undefined", HAVE_SANITIZER_UNDEFINED),
> FEATURE_STATUS("syscall_table", HAVE_SYSCALL_TABLE_SUPPORT),
> FEATURE_STATUS("zlib", HAVE_ZLIB_SUPPORT),
> FEATURE_STATUS("zstd", HAVE_ZSTD_SUPPORT),
> --
> 2.47.0.163.g1226f6d8fa-goog
>
Powered by blists - more mailing lists