linux-kernel - Re: [PATCH 1/2] ksmbd: fix possibly wrong init value for RDMA buffer size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAH2r5msTAPTtkkGftQ2yZK1KrQfp8gaf2QJqOF5Ewx947iMGvw@mail.gmail.com>
Date: Tue, 7 Jan 2025 17:32:00 -0600
From: Steve French <smfrench@...il.com>
To: Namjae Jeon <linkinjeon@...nel.org>
Cc: Tom Talpey <tom@...pey.com>, He Wang <xw897002528@...il.com>, 
	Steve French <sfrench@...ba.org>, Sergey Senozhatsky <senozhatsky@...omium.org>, linux-cifs@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] ksmbd: fix possibly wrong init value for RDMA buffer size

On Tue, Jan 7, 2025 at 5:14 PM Namjae Jeon <linkinjeon@...nel.org> wrote:
>
> On Wed, Jan 8, 2025 at 6:04 AM Tom Talpey <tom@...pey.com> wrote:
> >
> > I do not believe this is correct, what "man page" are you referring to?
> > The commit message is definitely wrong. Neither value is referring to
> > generic "maximum packets" nor "incoming requests".
> >
> > The max_qp_rd_atom is the "ORD" or outgoing read/atomic request depth.
> > The ksmbd server uses this to control RDMA Read requests to fetch data
> > from the client for certain SMB3_WRITE operations. (SMB Direct does not
> > use atomics)
> >
> > The max_qp_init_rd_atom is the "IRD" or incoming read/atomic request
> > depth. The SMB3 protocol does not allow clients to request data from
> > servers via RDMA Read. This is absolutely by design, and the server
> > therefore does not use this value.
> >
> > In practice, many RDMA providers set the rd_atom and rd_init_atom to
> > the same value, but this change would appear to break SMB Direct write
> > functionality when operating over providers that do not.
> >
> > So, NAK.
> >
> > Namjae, you should revert your upstream commit.
> Okay, Thanks for your review:)
> Steve, Please revert it in ksmbd-for-next also.


I have removed  "ksmbd: fix possibly wrong init value for RDMA buffer
size" so ksmbd-for-next currently has only these four:

37a11d8b2993 (HEAD -> ksmbd-for-next, origin/ksmbd-for-next) ksmbd:
Implement new SMB3 POSIX type
2ac538e40278 ksmbd: fix unexpectedly changed path in ksmbd_vfs_kern_path_locked
c7f3cd1b245d ksmbd: Remove unneeded if check in ksmbd_rdma_capable_netdev()
4c16e1cadcbc ksmbd: fix a missing return value check bug


-- 
Thanks,

Steve