linux-kernel - Re: [PATCH] ASoC: sun4i-codec: Use new devm clk and reset APIs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ddbbc928-f199-44df-918f-9a87b489718c@sirena.org.uk>
Date: Tue, 7 Jan 2025 23:49:06 +0000
From: Mark Brown <broonie@...nel.org>
To: Bence Csókás <csokas.bence@...lan.hu>
Cc: linux-sound@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-sunxi@...ts.linux.dev, linux-kernel@...r.kernel.org,
	Liam Girdwood <lgirdwood@...il.com>,
	Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
	Chen-Yu Tsai <wens@...e.org>,
	Jernej Skrabec <jernej.skrabec@...il.com>,
	Samuel Holland <samuel@...lland.org>,
	Philipp Zabel <p.zabel@...gutronix.de>
Subject: Re: [PATCH] ASoC: sun4i-codec: Use new devm clk and reset APIs

On Wed, Dec 11, 2024 at 11:22:05PM +0100, Bence Csókás wrote:
> Clean up error handling by using the new devm_
> clock and reset functions. This should make it
> easier to add new code, as we can eliminate the
> "goto ladder" in probe().

This breaks an allmodconfig build:

/build/stage/linux/sound/soc/sunxi/sun4i-codec.c: In function ‘sun4i_codec_remove’:
/build/stage/linux/sound/soc/sunxi/sun4i-codec.c:2380:29: error: unused variable ‘scodec’ [-Werror=unused-variable]
 2380 |         struct sun4i_codec *scodec = snd_soc_card_get_drvdata(card);
      |                             ^~~~~~


Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)