linux-kernel - [PATCH] mm: avoid implicit type conversion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250107035141.2858582-1-chao.shun.cheng.tw@gmail.com>
Date: Tue,  7 Jan 2025 11:51:41 +0800
From: Kenny Cheng <chao.shun.cheng.tw@...il.com>
To: hannes@...xchg.org,
	muchun.song@...ux.dev
Cc: cgroups@...r.kernel.org,
	linux-mm@...ck.org,
	linux-kernel@...r.kernel.org,
	c.s.cheng@...ltek.com,
	Kenny Cheng <chao.shun.cheng.tw@...il.com>
Subject: [PATCH] mm: avoid implicit type conversion

The function 'task_in_memcg_oom' returns a 'struct mem_cgroup *' type.
If the compiler does not inline this function, a compile error occurs,
as shown below:

./include/linux/memcontrol.h:961:9: error: incompatible pointer to 
integer conversion returning 'struct mem_cgroup *' from a function with
result type 'unsigned char' [-Wint-conversion]

This patch avoids the implicit type conversion by ensuring the return
type is correct.

Signed-off-by: Kenny Cheng <chao.shun.cheng.tw@...il.com>
---
 include/linux/memcontrol.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h
index 5502aa8e138e..47acf1e4f5a7 100644
--- a/include/linux/memcontrol.h
+++ b/include/linux/memcontrol.h
@@ -1826,7 +1826,7 @@ bool mem_cgroup_oom_synchronize(bool wait);
 
 static inline bool task_in_memcg_oom(struct task_struct *p)
 {
-	return p->memcg_in_oom;
+	return !!p->memcg_in_oom;
 }
 
 static inline void mem_cgroup_enter_user_fault(void)
-- 
2.34.1