linux-kernel - Re: [PATCH v3 1/7] dt-bindings: mailbox: mediatek: Add MT8196 support for gce-mailbox

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <42def68200b28b5bea3cbf091907343976482132.camel@mediatek.com>
Date: Tue, 7 Jan 2025 07:26:43 +0000
From: Jason-JH Lin (林睿祥) <Jason-JH.Lin@...iatek.com>
To: "krzk@...nel.org" <krzk@...nel.org>
CC: "robh@...nel.org" <robh@...nel.org>, "linux-media@...r.kernel.org"
	<linux-media@...r.kernel.org>, "simona@...ll.ch" <simona@...ll.ch>,
	"mchehab@...nel.org" <mchehab@...nel.org>, AngeloGioacchino Del Regno
	<angelogioacchino.delregno@...labora.com>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, Project_Global_Chrome_Upstream_Group
	<Project_Global_Chrome_Upstream_Group@...iatek.com>, "conor+dt@...nel.org"
	<conor+dt@...nel.org>, "linux-mediatek@...ts.infradead.org"
	<linux-mediatek@...ts.infradead.org>, "chunkuang.hu@...nel.org"
	<chunkuang.hu@...nel.org>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, "krzk+dt@...nel.org" <krzk+dt@...nel.org>,
	"jassisinghbrar@...il.com" <jassisinghbrar@...il.com>,
	Singo Chang (張興國) <Singo.Chang@...iatek.com>,
	Nancy Lin (林欣螢) <Nancy.Lin@...iatek.com>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "airlied@...il.com"
	<airlied@...il.com>, "dri-devel@...ts.freedesktop.org"
	<dri-devel@...ts.freedesktop.org>, "matthias.bgg@...il.com"
	<matthias.bgg@...il.com>, Moudy Ho (何宗原)
	<Moudy.Ho@...iatek.com>, Xavier Chang (張獻文)
	<Xavier.Chang@...iatek.com>
Subject: Re: [PATCH v3 1/7] dt-bindings: mailbox: mediatek: Add MT8196 support
 for gce-mailbox

On Tue, 2025-01-07 at 07:16 +0100, Krzysztof Kozlowski wrote:
> 
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> 
> 
> On 07/01/2025 03:42, Jason-JH Lin (林睿祥) wrote:
> > > 
> > > Before proceeding with this header further, please answer to
> > > above -
> > > why
> > > interrupt numbers, MMIO addresses and some other values appearing
> > > in
> > > DTS
> > > are not used like "binding headers".
> > 
> > Because interrupt numbers and MMIO addresses are the real numbers
> > of
> > hardware settings. Their driver can get them directly from their
> > device
> > node in DTS. They are actual number to be set into their hardware,
> > so
> > they don't need to be translated in their platform drivers.
> > 
> > So I think all the definitions in the `mediatek,mt8196-gce.h` are
> > the
> > same case. They are actual hardware numbers for GCE hardware to
> > use.
> > It should be drop from the include/dt-bindings/*.
> 
> I did not inspect all of the defines you have there. Maybe some are
> used
> by driver, so I did not provide you definitive answer on entire
> header.
> The comment was addressing one specific group of defines which were
> not
> used as a binding.

All of the gce binding headers in `include/dt-bindings/gce/*` or
`include/dt-bindings/mailbox/*` are not used in any drivers and they
are the actual hardware IDs or settings for GCE, not the abstract
bindings.

Maybe it is added in the wrong place from the very first time.
I think they should be moved to dts folder to make it correct.

> 
> > 
> > 
> > BTW, to make these numbers more readable in DTS, can I move
> > `include/dt-bindings/mailbox/mediatek,mt8196-gce.h` into
> > `arch/arm64/boot/dts/mediatek/mt8196-gce.h`?
> 
> Yes, sure.

OK, then I'll move it.

Thanks for your patience to let me make it clear.

Regards,
Jason-JH.Lin

> 
> > 
> > Just like the `arch/arm64/boot/dts/mediatek/mt8167-pinfunc.h`.
> 
> Best regards,
> Krzysztof