linux-kernel - Re: [PATCH v3 2/7] dt-bindings: PCI: dw: rockchip: Add rk3576 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <336b4eff-9d77-47ac-be26-2f73e30a5766@kernel.org>
Date: Tue, 7 Jan 2025 08:39:30 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Kever Yang <kever.yang@...k-chips.com>,
 "Rob Herring (Arm)" <robh@...nel.org>
Cc: linux-kernel@...r.kernel.org, heiko@...ech.de,
 Lorenzo Pieralisi <lpieralisi@...nel.org>,
 linux-arm-kernel@...ts.infradead.org, Simon Xue <xxm@...k-chips.com>,
 linux-rockchip@...ts.infradead.org,
 Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
 Bjorn Helgaas <bhelgaas@...gle.com>, Krzysztof Kozlowski
 <krzk+dt@...nel.org>, Krzysztof Wilczyński <kw@...ux.com>,
 linux-pci@...r.kernel.org, devicetree@...r.kernel.org,
 Conor Dooley <conor+dt@...nel.org>, Shawn Lin <shawn.lin@...k-chips.com>
Subject: Re: [PATCH v3 2/7] dt-bindings: PCI: dw: rockchip: Add rk3576 support

On 07/01/2025 08:24, Kever Yang wrote:
> Hi Rob,
> 
> On 2024/12/23 20:30, Rob Herring (Arm) wrote:
>> On Mon, 23 Dec 2024 19:06:32 +0800, Kever Yang wrote:
>>> rk3576 is using dwc controller, with msi interrupt directly to gic instead
>>> of to gic its, so
>>> - no its suport is required and the 'msi-map' is not need anymore,
>>> - a new 'msi' interrupt is needed.
>>>
>>> Signed-off-by: Kever Yang<kever.yang@...k-chips.com>
>>> ---
>>>
>>> Changes in v3:
>>> - Fix dtb check broken on rk3588
>>> - Update commit message
>>>
>>> Changes in v2:
>>> - remove required 'msi-map'
>>> - add interrupt name 'msi'
>>>
>>>   .../devicetree/bindings/pci/rockchip-dw-pcie-common.yaml      | 4 +++-
>>>   Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml   | 4 +---
>>>   2 files changed, 4 insertions(+), 4 deletions(-)
>>>
>> My bot found errors running 'make dt_binding_check' on your patch:
>>
>> yamllint warnings/errors:
>> ./Documentation/devicetree/bindings/pci/rockchip-dw-pcie-common.yaml:85:9: [warning] wrong indentation: expected 10 but found 8 (indentation)
> 
> Sorry, I'm not so good at the yaml grammar, I will fix it in next version.
> 
> But when I run the make dt_binding_check, I can't find this warning in 
> my side, maybe the tool has version required?


Read the full instruction (it is there on purpose, to avoid trivial
questions):

> 
> 
> Thanks,
> - Kever
>>
>> dtschema/dtc warnings/errors:
>>
>> doc reference errors (make refcheckdocs):
>>
>> Seehttps://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241223110637.3697974-3-kever.yang@rock-chips.com
>>
>> The base for the series is generally the latest rc1. A different dependency
>> should be noted in *this* patch.
>>
>> If you already ran 'make dt_binding_check' and didn't see the above
>> error(s), then make sure 'yamllint' is installed and dt-schema is up to
>> date:
>>
>> pip3 install dtschema --upgrade


Down to here. All above is fine on your side?



Best regards,
Krzysztof