linux-kernel - Re: [PATCH 1/1] usb: typec: tcpm: set SRC_SEND_CAPABILITIES timeout to PD_T_SENDER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z3z92o0XlaqXLwrb@kuha.fi.intel.com>
Date: Tue, 7 Jan 2025 12:11:38 +0200
From: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
To: joswang <joswang1221@...il.com>,
	Badhri Jagan Sridharan <badhri@...gle.com>
Cc: dmitry.baryshkov@...aro.org, gregkh@...uxfoundation.org,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	Jos Wang <joswang@...ovo.com>, stable@...r.kernel.org
Subject: Re: [PATCH 1/1] usb: typec: tcpm: set SRC_SEND_CAPABILITIES timeout
 to PD_T_SENDER_RESPONSE

+Badhri

On Sun, Jan 05, 2025 at 09:52:45PM +0800, joswang wrote:
> From: Jos Wang <joswang@...ovo.com>
> 
> As PD2.0 spec ("8.3.3.2.3 PE_SRC_Send_Capabilities state"), after the
> Source receives the GoodCRC Message from the Sink in response to the
> Source_Capabilities message, it should start the SenderResponseTimer,
> after the timer times out, the state machine transitions to the
> HARD_RESET state.
> 
> Fixes: f0690a25a140 ("staging: typec: USB Type-C Port Manager (tcpm)")
> Cc: stable@...r.kernel.org
> Signed-off-by: Jos Wang <joswang@...ovo.com>
> ---
>  drivers/usb/typec/tcpm/tcpm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c
> index 460dbde9fe22..57fae1118ac9 100644
> --- a/drivers/usb/typec/tcpm/tcpm.c
> +++ b/drivers/usb/typec/tcpm/tcpm.c
> @@ -4821,7 +4821,7 @@ static void run_state_machine(struct tcpm_port *port)
>  			port->caps_count = 0;
>  			port->pd_capable = true;
>  			tcpm_set_state_cond(port, SRC_SEND_CAPABILITIES_TIMEOUT,
> -					    PD_T_SEND_SOURCE_CAP);
> +					    PD_T_SENDER_RESPONSE);
>  		}
>  		break;
>  	case SRC_SEND_CAPABILITIES_TIMEOUT:

This looks okay to me, but let's get comments from Badhri, just in
case.

thanks,

-- 
heikki