linux-kernel - Re: [PATCH v2 1/3] kbuild: rust: add `CONFIG_RUSTC_CLANG_LLVM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87sepu6g01.fsf@kernel.org>
Date: Tue, 07 Jan 2025 12:29:39 +0100
From: Andreas Hindborg <a.hindborg@...nel.org>
To: "Gary Guo" <gary@...yguo.net>
Cc: "Miguel Ojeda" <ojeda@...nel.org>,  "Alex Gaynor"
 <alex.gaynor@...il.com>,  "Boqun Feng" <boqun.feng@...il.com>,
  =?utf-8?Q?Bj=C3=B6rn?= Roy
 Baron <bjorn3_gh@...tonmail.com>,  "Benno Lossin"
 <benno.lossin@...ton.me>,  "Alice Ryhl" <aliceryhl@...gle.com>,  "Trevor
 Gross" <tmgross@...ch.edu>,  "Nathan Chancellor" <nathan@...nel.org>,
  "Nick Desaulniers" <ndesaulniers@...gle.com>,  "Bill Wendling"
 <morbo@...gle.com>,  "Justin Stitt" <justinstitt@...gle.com>,  "Masahiro
 Yamada" <masahiroy@...nel.org>,  "Andrew Morton"
 <akpm@...ux-foundation.org>,  "Petr Mladek" <pmladek@...e.com>,  "Tejun
 Heo" <tj@...nel.org>,  "Yoann Congal" <yoann.congal@...le.fr>,  "Roman
 Gushchin" <roman.gushchin@...ux.dev>,  "Jens Axboe" <axboe@...nel.dk>,
  "Chen Ridong" <chenridong@...wei.com>,  "Jann Horn" <jannh@...gle.com>,
  "Mark Rutland" <mark.rutland@....com>,  "Vincent Guittot"
 <vincent.guittot@...aro.org>,  <rust-for-linux@...r.kernel.org>,
  <llvm@...ts.linux.dev>,  <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 1/3] kbuild: rust: add
 `CONFIG_RUSTC_CLANG_LLVM_COMPATIBLE`

"Gary Guo" <gary@...yguo.net> writes:

> This config detects if Rust and Clang have matching LLVM major version.
> All IR or bitcode operations (e.g. LTO) rely on LLVM major version to be
> matching, otherwise it may generate errors, or worse, miscompile silently
> due to change of IR semantics.
>
> It's usually suggested to use the exact same LLVM version, but this can
> be difficult to guarantee. Rust's suggestion [1] is also major-version only,
> so I think this check is sufficient for the kernel.
>
> Link: https://doc.rust-lang.org/rustc/linker-plugin-lto.html [1]
> Signed-off-by: Gary Guo <gary@...yguo.net>


Reviewed-by: Andreas Hindborg <a.hindborg@...nel.org>


Best regards,
Andreas Hindborg