linux-kernel - Re: [PATCH] checkpatch: Tolerate upstream commit references

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <878qrmlthe.fsf@nvidia.com>
Date: Tue, 7 Jan 2025 12:55:45 +0100
From: Petr Machata <petrm@...dia.com>
To: Petr Machata <petrm@...dia.com>
CC: Andy Whitcroft <apw@...onical.com>, Joe Perches <joe@...ches.com>,
	Dwaipayan Ray <dwaipayanray1@...il.com>, Lukas Bulwahn
	<lukas.bulwahn@...il.com>, <linux-kernel@...r.kernel.org>, Andy Roulin
	<aroulin@...dia.com>
Subject: Re: [PATCH] checkpatch: Tolerate upstream commit references


Petr Machata <petrm@...dia.com> writes:

> Two forms of upstream commit references are used (and documented) for
> stable kernels:
>
> - [ Upstream commit <sha1> ]
> - commit <sha1> upstream.
>
> These are useful apart from stable kernel trees to other downstream
> maintainers that wish to keep track of what came from where. But
> checkpatch gives citations on patches annotated this way.
>
> Extend checkpatch to tolerate the documented upstream references. This
> reduces noise for downstream maintainers.
>
> Signed-off-by: Petr Machata <petrm@...dia.com>
> Reviewed-by: Andy Roulin <aroulin@...dia.com>

Hello y'all all and happy 2025!

I sent this towards the end of the year, and understandably people were
busy around New Year's. This is to try and make sure the patch doesn't
get lost in last year's mailing, and ask for a bit of an attention from
maintainers.

Thanks!

> ---
>  scripts/checkpatch.pl | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 9eed3683ad76..a6c81b38e413 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -3340,6 +3340,8 @@ sub process {
>  		if ($perl_version_ok &&
>  		    $in_commit_log && !$commit_log_possible_stack_dump &&
>  		    $line !~ /^\s*(?:Link|Patchwork|http|https|BugLink|base-commit):/i &&
> +		    $line !~ /^\s*\[ Upstream commit [0-9a-f]{40} ]/ &&
> +		    $line !~ /^\s*commit [0-9a-f]{40}\s*upstream\./ &&
>  		    $line !~ /^This reverts commit [0-9a-f]{7,40}/ &&
>  		    (($line =~ /\bcommit\s+[0-9a-f]{5,}\b/i ||
>  		      ($line =~ /\bcommit\s*$/i && defined($rawlines[$linenr]) && $rawlines[$linenr] =~ /^\s*[0-9a-f]{5,}\b/i)) ||