linux-kernel - Re: [PATCH v11 0/4] io-pgtable-arm + drm/msm: Extend iova fault debugging

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250107125840.GB6991@willie-the-truck>
Date: Tue, 7 Jan 2025 12:58:41 +0000
From: Will Deacon <will@...nel.org>
To: Mostafa Saleh <smostafa@...gle.com>
Cc: Rob Clark <robdclark@...il.com>, iommu@...ts.linux.dev,
	linux-arm-msm@...r.kernel.org, freedreno@...ts.freedesktop.org,
	Rob Clark <robdclark@...omium.org>,
	"open list:DRM DRIVER for Qualcomm Adreno GPUs" <dri-devel@...ts.freedesktop.org>,
	Jason Gunthorpe <jgg@...pe.ca>,
	Joao Martins <joao.m.martins@...cle.com>,
	Kevin Tian <kevin.tian@...el.com>,
	Konrad Dybcio <konradybcio@...nel.org>,
	"moderated list:ARM SMMU DRIVERS" <linux-arm-kernel@...ts.infradead.org>,
	open list <linux-kernel@...r.kernel.org>,
	"open list:SUSPEND TO RAM" <linux-pm@...r.kernel.org>,
	Marijn Suijten <marijn.suijten@...ainline.org>,
	"Rafael J. Wysocki" <rafael@...nel.org>,
	Robin Murphy <robin.murphy@....com>,
	Ryan Roberts <ryan.roberts@....com>, Sean Paul <sean@...rly.run>
Subject: Re: [PATCH v11 0/4] io-pgtable-arm + drm/msm: Extend iova fault
 debugging

On Tue, Jan 07, 2025 at 12:55:55PM +0000, Mostafa Saleh wrote:
> On Tue, Dec 10, 2024 at 08:51:18AM -0800, Rob Clark wrote:
> > From: Rob Clark <robdclark@...omium.org>
> > 
> > This series extends io-pgtable-arm with a method to retrieve the page
> > table entries traversed in the process of address translation, and then
> > beefs up drm/msm gpu devcore dump to include this (and additional info)
> > in the devcore dump.
> > 
> > This is a respin of https://patchwork.freedesktop.org/series/94968/
> > (minus a patch that was already merged)
> > 
> > v2:  Fix an armv7/32b build error in the last patch
> > v3:  Incorperate Will Deacon's suggestion to make the interface
> >      callback based.
> > v4:  Actually wire up the callback
> > v5:  Drop the callback approach
> > v6:  Make walk-data struct pgtable specific and rename
> >      io_pgtable_walk_data to arm_lpae_io_pgtable_walk_data
> > v7:  Re-use the pgtable walker added for arm_lpae_read_and_clear_dirty()
> > v8:  Pass pte pointer to callback so it can modify the actual pte
> > v9:  Fix selftests_running case
> > v10: Call visit cb for all nodes traversed, leave the decision about
> >      whether to care about non-leaf nodes to the callback
> > v11: Adjust logic in 3/4 [smostafa@]
> 
> I see the level initialization was not removed as it was in the diff[1], so it
> seems to me that’s redundant as the level is set anyway in the callback, and
> actually looking at that I see it’s not used or printed from the driver,
> so may it can be removed all together, anyway that’s nit that may be Will can
> fix it up while merging.
> 
> Otherwise, For the whole series
> Reviewed-by: Mostafa Saleh <smostafa@...gle.com>

I'm happy to drop the 'level' field if it's not used. We can add it back
if/when it's needed. Rob?

Will