linux-kernel - Re: [PATCH V6 03/15] cpufreq: Rust implementation doesn't parse BIT() macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <37DAF91C-2A1B-4848-A66F-3B50285AFEBA@collabora.com>
Date: Tue, 7 Jan 2025 10:29:50 -0300
From: Daniel Almeida <daniel.almeida@...labora.com>
To: Greg KH <gregkh@...uxfoundation.org>
Cc: Viresh Kumar <viresh.kumar@...aro.org>,
 "Rafael J. Wysocki" <rafael@...nel.org>,
 Miguel Ojeda <miguel.ojeda.sandonis@...il.com>,
 Danilo Krummrich <dakr@...hat.com>,
 Miguel Ojeda <ojeda@...nel.org>,
 Alex Gaynor <alex.gaynor@...il.com>,
 Boqun Feng <boqun.feng@...il.com>,
 Gary Guo <gary@...yguo.net>,
 Björn Roy Baron <bjorn3_gh@...tonmail.com>,
 Benno Lossin <benno.lossin@...ton.me>,
 Andreas Hindborg <a.hindborg@...nel.org>,
 Alice Ryhl <aliceryhl@...gle.com>,
 Trevor Gross <tmgross@...ch.edu>,
 linux-pm@...r.kernel.org,
 Vincent Guittot <vincent.guittot@...aro.org>,
 Stephen Boyd <sboyd@...nel.org>,
 Nishanth Menon <nm@...com>,
 rust-for-linux@...r.kernel.org,
 Manos Pitsidianakis <manos.pitsidianakis@...aro.org>,
 Erik Schilling <erik.schilling@...aro.org>,
 Alex Bennée <alex.bennee@...aro.org>,
 Joakim Bech <joakim.bech@...aro.org>,
 Rob Herring <robh@...nel.org>,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH V6 03/15] cpufreq: Rust implementation doesn't parse BIT()
 macro

Hi,

> On 7 Jan 2025, at 09:00, Greg KH <gregkh@...uxfoundation.org> wrote:
> 
> On Tue, Jan 07, 2025 at 04:51:36PM +0530, Viresh Kumar wrote:
>> Rust isn't able to parse the macro for now, avoid using it.
> 
> No, please fix it.  You don't want to have to fend off the checkpatch.pl
> cleanups that this would cause of people putting the BIT() macro back.
> 
> Make BIT() work properly for Rust code as well, it has to be done
> eventually, right?
> 
> thanks,
> 
> greg k-h
> 

Viresh, FYI, there’s already a patch for this floating around [0].

I can send a new version today. From Alice’s last comments, it only
needs a minor fix anyways.

— Daniel

[0] https://lore.kernel.org/rust-for-linux/20241024-topic-panthor-rs-genmask-v2-1-85237c1f0cea@collabora.com/