linux-kernel - RE: [EXTERNAL] [PATCH net-next v03 1/1] hinic3: module initialization and tx/rx logic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250107140342.3553459-1-gur.stavi@huawei.com>
Date: Tue, 7 Jan 2025 16:03:42 +0200
From: Gur Stavi <gur.stavi@...wei.com>
To: <sumang@...vell.com>
CC: <andrew+netdev@...n.ch>, <cai.huoqing@...ux.dev>, <corbet@....net>,
	<davem@...emloft.net>, <edumazet@...gle.com>, <gongfan1@...wei.com>,
	<guoxin09@...wei.com>, <gur.stavi@...wei.com>, <helgaas@...nel.org>,
	<horms@...nel.org>, <kuba@...nel.org>, <linux-doc@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <meny.yossefi@...wei.com>,
	<netdev@...r.kernel.org>, <pabeni@...hat.com>, <shenchenyang1@...ilicon.com>,
	<shijing34@...wei.com>, <wulike1@...wei.com>, <zhoushuai28@...wei.com>
Subject: RE: [EXTERNAL] [PATCH net-next v03 1/1] hinic3: module initialization and tx/rx logic

> >+static int comm_msg_to_mgmt_sync(struct hinic3_hwdev *hwdev, u16 cmd,
> >const void *buf_in,
> >+				 u32 in_size, void *buf_out, u32 *out_size)
> >+{
> >+	return hinic3_send_mbox_to_mgmt(hwdev, HINIC3_MOD_COMM, cmd,
> >buf_in,
> >+					in_size, buf_out, out_size, 0);
> >+}
> [Suman] Any reason we need this wrapper? We can directly call hinic3_send_m=
> box_to_mgmt() from hinic3_func_reset()

This wrapper is used frequently (10 times or more) and it reduces number
of parameters from 8 to 6.

> >+