| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20250107135133.GA3765919@ragnatech.se>
Date: Tue, 7 Jan 2025 14:51:33 +0100
From: Niklas Söderlund <niklas.soderlund@...natech.se>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc: Daniel Lezcano <daniel.lezcano@...aro.org>,
Thomas Gleixner <tglx@...utronix.de>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>,
Maxime Coquelin <mcoquelin.stm32@...il.com>,
Alexandre Torgue <alexandre.torgue@...s.st.com>,
Paul Walmsley <paul.walmsley@...ive.com>,
Samuel Holland <samuel.holland@...ive.com>,
Geert Uytterhoeven <geert+renesas@...der.be>,
Magnus Damm <magnus.damm@...il.com>,
Laurent Pinchart <laurent.pinchart+renesas@...asonboard.com>,
Chris Brandt <chris.brandt@...esas.com>,
Yoshinori Sato <ysato@...rs.sourceforge.jp>,
Palmer Dabbelt <palmer@...belt.com>,
Anup Patel <anup@...infault.org>, linux-kernel@...r.kernel.org,
devicetree@...r.kernel.org,
linux-stm32@...md-mailman.stormreply.com,
linux-arm-kernel@...ts.infradead.org,
linux-riscv@...ts.infradead.org, linux-renesas-soc@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: timer: Correct indentation and style in DTS
example
Hello Krzysztof,
Thanks for your work.
On 2025-01-07 14:10:22 +0100, Krzysztof Kozlowski wrote:
> DTS example in the bindings should be indented with 2- or 4-spaces and
> aligned with opening '- |', so correct any differences like 3-spaces or
> mixtures 2- and 4-spaces in one binding.
>
> No functional changes here, but saves some comments during reviews of
> new patches built on existing code.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
For renesas,*
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@...natech.se>
> ---
> .../bindings/timer/arm,twd-timer.yaml | 6 +--
> .../bindings/timer/renesas,cmt.yaml | 44 +++++++++----------
> .../bindings/timer/renesas,em-sti.yaml | 10 ++---
> .../bindings/timer/renesas,mtu2.yaml | 14 +++---
> .../bindings/timer/renesas,ostm.yaml | 10 ++---
> .../bindings/timer/renesas,tmu.yaml | 22 +++++-----
> .../bindings/timer/renesas,tpu.yaml | 8 ++--
> .../bindings/timer/sifive,clint.yaml | 2 +-
> 8 files changed, 58 insertions(+), 58 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/timer/arm,twd-timer.yaml b/Documentation/devicetree/bindings/timer/arm,twd-timer.yaml
> index 5684df6448ef..eb1127352c7b 100644
> --- a/Documentation/devicetree/bindings/timer/arm,twd-timer.yaml
> +++ b/Documentation/devicetree/bindings/timer/arm,twd-timer.yaml
> @@ -50,7 +50,7 @@ examples:
> #include <dt-bindings/interrupt-controller/arm-gic.h>
>
> timer@...00600 {
> - compatible = "arm,arm11mp-twd-timer";
> - reg = <0x2c000600 0x20>;
> - interrupts = <GIC_PPI 13 0xf01>;
> + compatible = "arm,arm11mp-twd-timer";
> + reg = <0x2c000600 0x20>;
> + interrupts = <GIC_PPI 13 0xf01>;
> };
> diff --git a/Documentation/devicetree/bindings/timer/renesas,cmt.yaml b/Documentation/devicetree/bindings/timer/renesas,cmt.yaml
> index 5e09c04da30e..260b05f213e6 100644
> --- a/Documentation/devicetree/bindings/timer/renesas,cmt.yaml
> +++ b/Documentation/devicetree/bindings/timer/renesas,cmt.yaml
> @@ -178,29 +178,29 @@ examples:
> #include <dt-bindings/interrupt-controller/arm-gic.h>
> #include <dt-bindings/power/r8a7790-sysc.h>
> cmt0: timer@...a0000 {
> - compatible = "renesas,r8a7790-cmt0", "renesas,rcar-gen2-cmt0";
> - reg = <0xffca0000 0x1004>;
> - interrupts = <GIC_SPI 142 IRQ_TYPE_LEVEL_HIGH>,
> - <GIC_SPI 143 IRQ_TYPE_LEVEL_HIGH>;
> - clocks = <&cpg CPG_MOD 124>;
> - clock-names = "fck";
> - power-domains = <&sysc R8A7790_PD_ALWAYS_ON>;
> - resets = <&cpg 124>;
> + compatible = "renesas,r8a7790-cmt0", "renesas,rcar-gen2-cmt0";
> + reg = <0xffca0000 0x1004>;
> + interrupts = <GIC_SPI 142 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 143 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&cpg CPG_MOD 124>;
> + clock-names = "fck";
> + power-domains = <&sysc R8A7790_PD_ALWAYS_ON>;
> + resets = <&cpg 124>;
> };
>
> cmt1: timer@...30000 {
> - compatible = "renesas,r8a7790-cmt1", "renesas,rcar-gen2-cmt1";
> - reg = <0xe6130000 0x1004>;
> - interrupts = <GIC_SPI 120 IRQ_TYPE_LEVEL_HIGH>,
> - <GIC_SPI 121 IRQ_TYPE_LEVEL_HIGH>,
> - <GIC_SPI 122 IRQ_TYPE_LEVEL_HIGH>,
> - <GIC_SPI 123 IRQ_TYPE_LEVEL_HIGH>,
> - <GIC_SPI 124 IRQ_TYPE_LEVEL_HIGH>,
> - <GIC_SPI 125 IRQ_TYPE_LEVEL_HIGH>,
> - <GIC_SPI 126 IRQ_TYPE_LEVEL_HIGH>,
> - <GIC_SPI 127 IRQ_TYPE_LEVEL_HIGH>;
> - clocks = <&cpg CPG_MOD 329>;
> - clock-names = "fck";
> - power-domains = <&sysc R8A7790_PD_ALWAYS_ON>;
> - resets = <&cpg 329>;
> + compatible = "renesas,r8a7790-cmt1", "renesas,rcar-gen2-cmt1";
> + reg = <0xe6130000 0x1004>;
> + interrupts = <GIC_SPI 120 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 121 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 122 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 123 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 124 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 125 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 126 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 127 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&cpg CPG_MOD 329>;
> + clock-names = "fck";
> + power-domains = <&sysc R8A7790_PD_ALWAYS_ON>;
> + resets = <&cpg 329>;
> };
> diff --git a/Documentation/devicetree/bindings/timer/renesas,em-sti.yaml b/Documentation/devicetree/bindings/timer/renesas,em-sti.yaml
> index 233d74d5402c..a7385d865bca 100644
> --- a/Documentation/devicetree/bindings/timer/renesas,em-sti.yaml
> +++ b/Documentation/devicetree/bindings/timer/renesas,em-sti.yaml
> @@ -38,9 +38,9 @@ examples:
> - |
> #include <dt-bindings/interrupt-controller/arm-gic.h>
> timer@...80000 {
> - compatible = "renesas,em-sti";
> - reg = <0xe0180000 0x54>;
> - interrupts = <GIC_SPI 125 IRQ_TYPE_LEVEL_HIGH>;
> - clocks = <&sti_sclk>;
> - clock-names = "sclk";
> + compatible = "renesas,em-sti";
> + reg = <0xe0180000 0x54>;
> + interrupts = <GIC_SPI 125 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&sti_sclk>;
> + clock-names = "sclk";
> };
> diff --git a/Documentation/devicetree/bindings/timer/renesas,mtu2.yaml b/Documentation/devicetree/bindings/timer/renesas,mtu2.yaml
> index 15d8dddf4ae9..e56c12f03f72 100644
> --- a/Documentation/devicetree/bindings/timer/renesas,mtu2.yaml
> +++ b/Documentation/devicetree/bindings/timer/renesas,mtu2.yaml
> @@ -66,11 +66,11 @@ examples:
> #include <dt-bindings/clock/r7s72100-clock.h>
> #include <dt-bindings/interrupt-controller/arm-gic.h>
> mtu2: timer@...f0000 {
> - compatible = "renesas,mtu2-r7s72100", "renesas,mtu2";
> - reg = <0xfcff0000 0x400>;
> - interrupts = <GIC_SPI 107 IRQ_TYPE_LEVEL_HIGH>;
> - interrupt-names = "tgi0a";
> - clocks = <&mstp3_clks R7S72100_CLK_MTU2>;
> - clock-names = "fck";
> - power-domains = <&cpg_clocks>;
> + compatible = "renesas,mtu2-r7s72100", "renesas,mtu2";
> + reg = <0xfcff0000 0x400>;
> + interrupts = <GIC_SPI 107 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-names = "tgi0a";
> + clocks = <&mstp3_clks R7S72100_CLK_MTU2>;
> + clock-names = "fck";
> + power-domains = <&cpg_clocks>;
> };
> diff --git a/Documentation/devicetree/bindings/timer/renesas,ostm.yaml b/Documentation/devicetree/bindings/timer/renesas,ostm.yaml
> index e8c642166462..9ba858f094ab 100644
> --- a/Documentation/devicetree/bindings/timer/renesas,ostm.yaml
> +++ b/Documentation/devicetree/bindings/timer/renesas,ostm.yaml
> @@ -71,9 +71,9 @@ examples:
> #include <dt-bindings/clock/r7s72100-clock.h>
> #include <dt-bindings/interrupt-controller/arm-gic.h>
> ostm0: timer@...ec000 {
> - compatible = "renesas,r7s72100-ostm", "renesas,ostm";
> - reg = <0xfcfec000 0x30>;
> - interrupts = <GIC_SPI 102 IRQ_TYPE_EDGE_RISING>;
> - clocks = <&mstp5_clks R7S72100_CLK_OSTM0>;
> - power-domains = <&cpg_clocks>;
> + compatible = "renesas,r7s72100-ostm", "renesas,ostm";
> + reg = <0xfcfec000 0x30>;
> + interrupts = <GIC_SPI 102 IRQ_TYPE_EDGE_RISING>;
> + clocks = <&mstp5_clks R7S72100_CLK_OSTM0>;
> + power-domains = <&cpg_clocks>;
> };
> diff --git a/Documentation/devicetree/bindings/timer/renesas,tmu.yaml b/Documentation/devicetree/bindings/timer/renesas,tmu.yaml
> index 75b0e7c70b62..b1229595acfb 100644
> --- a/Documentation/devicetree/bindings/timer/renesas,tmu.yaml
> +++ b/Documentation/devicetree/bindings/timer/renesas,tmu.yaml
> @@ -122,15 +122,15 @@ examples:
> #include <dt-bindings/interrupt-controller/arm-gic.h>
> #include <dt-bindings/power/r8a7779-sysc.h>
> tmu0: timer@...80000 {
> - compatible = "renesas,tmu-r8a7779", "renesas,tmu";
> - reg = <0xffd80000 0x30>;
> - interrupts = <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>,
> - <GIC_SPI 33 IRQ_TYPE_LEVEL_HIGH>,
> - <GIC_SPI 34 IRQ_TYPE_LEVEL_HIGH>,
> - <GIC_SPI 35 IRQ_TYPE_LEVEL_HIGH>;
> - interrupt-names = "tuni0", "tuni1", "tuni2", "ticpi2";
> - clocks = <&mstp0_clks R8A7779_CLK_TMU0>;
> - clock-names = "fck";
> - power-domains = <&sysc R8A7779_PD_ALWAYS_ON>;
> - #renesas,channels = <3>;
> + compatible = "renesas,tmu-r8a7779", "renesas,tmu";
> + reg = <0xffd80000 0x30>;
> + interrupts = <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 33 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 34 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 35 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-names = "tuni0", "tuni1", "tuni2", "ticpi2";
> + clocks = <&mstp0_clks R8A7779_CLK_TMU0>;
> + clock-names = "fck";
> + power-domains = <&sysc R8A7779_PD_ALWAYS_ON>;
> + #renesas,channels = <3>;
> };
> diff --git a/Documentation/devicetree/bindings/timer/renesas,tpu.yaml b/Documentation/devicetree/bindings/timer/renesas,tpu.yaml
> index 01554dff23d8..7a473b302775 100644
> --- a/Documentation/devicetree/bindings/timer/renesas,tpu.yaml
> +++ b/Documentation/devicetree/bindings/timer/renesas,tpu.yaml
> @@ -49,8 +49,8 @@ additionalProperties: false
> examples:
> - |
> tpu: tpu@...fe0 {
> - compatible = "renesas,tpu";
> - reg = <0xffffe0 16>, <0xfffff0 12>;
> - clocks = <&pclk>;
> - clock-names = "fck";
> + compatible = "renesas,tpu";
> + reg = <0xffffe0 16>, <0xfffff0 12>;
> + clocks = <&pclk>;
> + clock-names = "fck";
> };
> diff --git a/Documentation/devicetree/bindings/timer/sifive,clint.yaml b/Documentation/devicetree/bindings/timer/sifive,clint.yaml
> index b42d43d2de48..d6a73be66765 100644
> --- a/Documentation/devicetree/bindings/timer/sifive,clint.yaml
> +++ b/Documentation/devicetree/bindings/timer/sifive,clint.yaml
> @@ -76,6 +76,6 @@ examples:
> <&cpu2intc 3>, <&cpu2intc 7>,
> <&cpu3intc 3>, <&cpu3intc 7>,
> <&cpu4intc 3>, <&cpu4intc 7>;
> - reg = <0x2000000 0x10000>;
> + reg = <0x2000000 0x10000>;
> };
> ...
> --
> 2.43.0
>
>
--
Kind Regards,
Niklas Söderlund
Powered by blists - more mailing lists