linux-kernel - Re: [PATCH v4 4/9] i2c: use client addresses directly in ATR interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6115974.lOV4Wx5bFT@fw-rgant>
Date: Wed, 08 Jan 2025 14:31:16 +0100
From: Romain Gantois <romain.gantois@...tlin.com>
To: Tomi Valkeinen <tomi.valkeinen@...asonboard.com>
Cc: Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
 Kory Maincent <kory.maincent@...tlin.com>, linux-i2c@...r.kernel.org,
 linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
 linux-media@...r.kernel.org, linux-gpio@...r.kernel.org,
 Wolfram Sang <wsa+renesas@...g-engineering.com>,
 Luca Ceresoli <luca.ceresoli@...tlin.com>,
 Andi Shyti <andi.shyti@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
 Derek Kiernan <derek.kiernan@....com>, Dragan Cvetic <dragan.cvetic@....com>,
 Arnd Bergmann <arnd@...db.de>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Mauro Carvalho Chehab <mchehab@...nel.org>,
 Linus Walleij <linus.walleij@...aro.org>, Bartosz Golaszewski <brgl@...ev.pl>
Subject:
 Re: [PATCH v4 4/9] i2c: use client addresses directly in ATR interface

Hi,

On lundi 6 janvier 2025 10:51:20 heure normale d’Europe centrale Tomi 
Valkeinen wrote:
> Hi,
> 
> On 30/12/2024 15:22, Romain Gantois wrote:
> > The I2C Address Translator (ATR) module defines mappings from i2c_client
> > structs to aliases. However, only the physical address of each i2c_client
...
> > 
> > -	dev_dbg(atr->dev, "chan%u: client 0x%02x mapped at alias 0x%02x (%s)
\n",
> > -		chan->chan_id, client->addr, alias, client->name);
> > +	dev_dbg(atr->dev, "chan%u: addr 0x%02x mapped at alias 0x%02x\n",
> > +		chan->chan_id, addr, alias);
> 
> This, and the dev_dbg() below, sound a bit odd to my ear. But I'm not
> sure what would be a good print... "added alias 0x12 for address 0x34"?

Maybe "assigned address 0x34 to alias 0x12"? Since the alias doesn't really go 
anywhere, we just assign different downstream addresses to it.

Thanks,

-- 
Romain Gantois, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)