linux-kernel - Re: [PATCH v2 1/2] mm: alloc_pages_bulk_noprof: drop page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5724ae77-0863-4f8a-90ad-ebe2d2268eb1@redhat.com>
Date: Wed, 8 Jan 2025 14:39:54 +0100
From: David Hildenbrand <david@...hat.com>
To: Luiz Capitulino <luizcap@...hat.com>, linux-mm@...ck.org,
 mgorman@...hsingularity.net, willy@...radead.org
Cc: linux-kernel@...r.kernel.org, lcapitulino@...il.com
Subject: Re: [PATCH v2 1/2] mm: alloc_pages_bulk_noprof: drop page_list
 argument

On 23.12.24 23:00, Luiz Capitulino wrote:
> The commit 387ba26fb1cb ("mm/page_alloc: add a bulk page allocator") added
> __alloc_pages_bulk() along with the page_list argument. The next
> commit 0f87d9d30f21 ("mm/page_alloc: add an array-based interface to the
> bulk page allocator") added the array-based argument. As it turns out, the
> page_list argument has no users in the current tree (if it ever had any).
> Dropping it allows for a slight simplification and eliminates some
> unnecessary checks, now that page_array is required.
> 
> Also, note that the removal of the page_list argument was proposed before
> in the thread below, where Matthew Wilcox mentions that:
> 
>    """
>    Iterating a linked list is _expensive_.  It is about 10x quicker to
>    iterate an array than a linked list.
>    """
>    (https://lore.kernel.org/linux-mm/20231025093254.xvomlctwhcuerzky@techsingularity.net)
> 
> Signed-off-by: Luiz Capitulino <luizcap@...hat.com>
> ---

Acked-by: David Hildenbrand <david@...hat.com>

Thanks!

-- 
Cheers,

David / dhildenb