linux-kernel - Re: [PATCH 1/2] soc cache: Add framework driver for HiSilicon SoC cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202501082116.RY64zFEz-lkp@intel.com>
Date: Wed, 8 Jan 2025 21:54:47 +0800
From: kernel test robot <lkp@...el.com>
To: Yushan Wang <wangyushan12@...wei.com>, xuwei5@...ilicon.com,
	yangyicong@...ilicon.com, Jonathan.Cameron@...wei.com,
	wangjie125@...wei.com, linux-kernel@...r.kernel.org
Cc: oe-kbuild-all@...ts.linux.dev, prime.zeng@...ilicon.com,
	fanghao11@...wei.com, wangyushan12@...wei.com, linuxarm@...wei.com
Subject: Re: [PATCH 1/2] soc cache: Add framework driver for HiSilicon SoC
 cache

Hi Yushan,

kernel test robot noticed the following build warnings:

[auto build test WARNING on linus/master]
[also build test WARNING on v6.13-rc6 next-20250107]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Yushan-Wang/soc-cache-Add-framework-driver-for-HiSilicon-SoC-cache/20250107-213022
base:   linus/master
patch link:    https://lore.kernel.org/r/20250107132907.3521574-2-wangyushan12%40huawei.com
patch subject: [PATCH 1/2] soc cache: Add framework driver for HiSilicon SoC cache
config: arm-allmodconfig (https://download.01.org/0day-ci/archive/20250108/202501082116.RY64zFEz-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250108/202501082116.RY64zFEz-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202501082116.RY64zFEz-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/soc/hisilicon/hisi_soc_cache_framework.c: In function 'hisi_soc_cache_vm_close':
>> drivers/soc/hisilicon/hisi_soc_cache_framework.c:331:13: warning: variable 'ret' set but not used [-Wunused-but-set-variable]
     331 |         int ret;
         |             ^~~


vim +/ret +331 drivers/soc/hisilicon/hisi_soc_cache_framework.c

   327	
   328	static void hisi_soc_cache_vm_close(struct vm_area_struct *vma)
   329	{
   330		struct hisi_soc_cache_lock_region *clr = vma->vm_private_data;
 > 331		int ret;
   332	
   333		/*
   334		 * Only perform cache unlock when the vma passed in is created
   335		 * in hisi_soc_cache_mmap.
   336		 */
   337		if (clr->vm_start != vma->vm_start || clr->vm_end != vma->vm_end)
   338			return;
   339	
   340		ret = hisi_soc_cache_unlock(clr->cpu, clr->addr);
   341	
   342		hisi_soc_cache_aligned_free(clr);
   343		kfree(clr);
   344		vma->vm_private_data = NULL;
   345	}
   346	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki