linux-kernel - Re: [PATCH] staging: gpib: refer to correct config symbol in tnt4882 Makefile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <8ee50d2d-2c3d-495e-abd8-f0326ab16bd0@app.fastmail.com>
Date: Wed, 08 Jan 2025 15:04:40 +0100
From: "Arnd Bergmann" <arnd@...db.de>
To: "Lukas Bulwahn" <lbulwahn@...hat.com>,
 "Dave Penkler" <dpenkler@...il.com>,
 "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
 linux-staging@...ts.linux.dev
Cc: kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org,
 "Lukas Bulwahn" <lukas.bulwahn@...hat.com>
Subject: Re: [PATCH] staging: gpib: refer to correct config symbol in tnt4882 Makefile

On Tue, Jan 7, 2025, at 14:50, Lukas Bulwahn wrote:
> From: Lukas Bulwahn <lukas.bulwahn@...hat.com>
>
> Commit 79d2e1919a27 ("staging: gpib: fix Makefiles") uses the corresponding
> config symbols to let Makefiles include the driver sources appropriately in
> the kernel build.
>
> Unfortunately, the Makefile in the tnt4882 directory refers to the
> non-existing config GPIB_TNT4882. The actual config name for this driver is
> GPIB_NI_PCI_ISA, as can be observed in the gpib Makefile.
>
> Probably, this is caused by the subtle differences between the config
> names, directory names and file names in ./drivers/staging/gpib/, where
> often config names and directory names are identical or at least close in
> naming, but in this case, it is not.
>
> Change the reference in the tnt4882 Makefile from the non-existing config
> GPIB_TNT4882 to the existing config GPIB_NI_PCI_ISA.
>
> Fixes: 79d2e1919a27 ("staging: gpib: fix Makefiles")
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@...hat.com>

Acked-by: Arnd Bergmann <arnd@...db.de>