linux-kernel - Re: [PATCH] ASoC: renesas: rz-ssi: Add a check for negative sample

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <173634768360.57096.9164270045125879919.b4-ty@kernel.org>
Date: Wed, 08 Jan 2025 14:48:03 +0000
From: Mark Brown <broonie@...nel.org>
To: Biju Das <biju.das.jz@...renesas.com>, 
 Dan Carpenter <dan.carpenter@...aro.org>
Cc: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>, 
 Liam Girdwood <lgirdwood@...il.com>, Jaroslav Kysela <perex@...ex.cz>, 
 Takashi Iwai <tiwai@...e.com>, linux-sound@...r.kernel.org, 
 linux-renesas-soc@...r.kernel.org, linux-kernel@...r.kernel.org, 
 kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] ASoC: renesas: rz-ssi: Add a check for negative
 sample_space

On Wed, 08 Jan 2025 12:28:46 +0300, Dan Carpenter wrote:
> My static checker rule complains about this code.  The concern is that
> if "sample_space" is negative then the "sample_space >= runtime->channels"
> condition will not work as intended because it will be type promoted to a
> high unsigned int value.
> 
> strm->fifo_sample_size is SSI_FIFO_DEPTH (32).  The SSIFSR_TDC_MASK is
> 0x3f.  Without any further context it does seem like a reasonable warning
> and it can't hurt to add a check for negatives.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: renesas: rz-ssi: Add a check for negative sample_space
      commit: 82a0a3e6f8c02b3236b55e784a083fa4ee07c321

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark