linux-kernel - Re: [PATCH v1 25/29] cxl/amd: Enable Zen5 address translation using ACPI PRMT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z36RMyf21c3l2ilW@rric.localdomain>
Date: Wed, 8 Jan 2025 15:52:35 +0100
From: Robert Richter <rrichter@....com>
To: Gregory Price <gourry@...rry.net>
Cc: Alison Schofield <alison.schofield@...el.com>,
	Vishal Verma <vishal.l.verma@...el.com>,
	Ira Weiny <ira.weiny@...el.com>,
	Dan Williams <dan.j.williams@...el.com>,
	Jonathan Cameron <jonathan.cameron@...wei.com>,
	Dave Jiang <dave.jiang@...el.com>,
	Davidlohr Bueso <dave@...olabs.net>,
	Terry Bowman <terry.bowman@....com>, linux-cxl@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	"Fabio M. De Francesco" <fabio.m.de.francesco@...ux.intel.com>
Subject: Re: [PATCH v1 25/29] cxl/amd: Enable Zen5 address translation using
 ACPI PRMT

On 07.01.25 18:28:57, Gregory Price wrote:
> On Tue, Jan 07, 2025 at 03:10:11PM +0100, Robert Richter wrote:
> > 
> > Add a function cxl_port_setup_amd() to implement AMD platform specific
> > code. Use Kbuild and Kconfig options respectivly to enable the code
> > depending on architecture and platform options. Create a new file
> > core/amd.c for this.
> > 
> 
> A build option here specific to AMD doesn't seem the best. At Meta,
> we try to maintain a platform agnostic kernel for our fleet (at least
> for build options), and this would necessitate us maintaining separate
> builds for AMD systems vs other vendors.
> 
> Is there a reason to simply not include it by default and just report
> whether translation is required or not? (i.e. no build option)

There is no (menu) option for CXL_AMD, it is just checking the
dependencies to AMD_NB (and indirectly arch, platform and vendor). In
that case it is always enabled.

Thanks for review.

-Robert

> 
> Or maybe generalize to CXL_PLATFORM_QUIRKS rather than CXL_AMD?
> 
> ~Gregory