linux-kernel - Re: [PATCH] Bluetooth: Allow reset via sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABBYNZLEG4rQBM6WYyRNJwOYWQU2ajyCTxWwe3+6aCYm=Gk4dQ@mail.gmail.com>
Date: Wed, 8 Jan 2025 10:06:34 -0500
From: Luiz Augusto von Dentz <luiz.dentz@...il.com>
To: Greg KH <gregkh@...uxfoundation.org>
Cc: Hsin-chen Chuang <chharry@...omium.org>, linux-bluetooth@...r.kernel.org, 
	chromeos-bluetooth-upstreaming@...omium.org, 
	Johan Hedberg <johan.hedberg@...il.com>, Marcel Holtmann <marcel@...tmann.org>, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Bluetooth: Allow reset via sysfs

Hi Greg,

On Wed, Jan 8, 2025 at 7:34 AM Greg KH <gregkh@...uxfoundation.org> wrote:
>
> On Fri, Jan 03, 2025 at 11:20:20AM +0800, Hsin-chen Chuang wrote:
> > Allow sysfs to trigger reset via the cmd_timeout function in hci device.
> > This is required to recover devices that are not responsive from
> > userspace.
> >
> > Also remove the cmd timeout count in btusb since we only ever allow one
> > command in flight at a time. We should always reset after a single
> > command times out.
> >
> > Signed-off-by: Hsin-chen Chuang <chharry@...omium.org>
> > ---
> > This commit has been tested on a Chromebook by running
> > `echo 1 > /sys/class/bluetooth/hci0/reset`
>
> You forgot the required Documentation/ABI/ update for your new sysfs
> file :(

Looks like I've missed that when reviewing these changes, anyway no
pull-request has been made, I assume we should follow what is
documentation on Documentation/ABI/README? Does it include debugfs
entries as well or only sysfs are required to be documented?

> thanks,
>
> greg k-h



-- 
Luiz Augusto von Dentz