linux-kernel - Re: [PATCH] ACPI: PRM: Fix missing guid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250108151037.GA1221136@yaz-khff2.amd.com>
Date: Wed, 8 Jan 2025 10:10:37 -0500
From: Yazen Ghannam <yazen.ghannam@....com>
To: Robert Richter <rrichter@....com>
Cc: "Rafael J. Wysocki" <rafael@...nel.org>, Len Brown <lenb@...nel.org>,
	linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org,
	John Allen <john.allen@....com>, Borislav Petkov <bp@...en8.de>
Subject: Re: [PATCH] ACPI: PRM: Fix missing guid_t declaration in linux/prmt.h

On Tue, Jan 07, 2025 at 05:19:22PM +0100, Robert Richter wrote:
> Seen the following build error:
> 
>  ./include/linux/prmt.h:5:27: error: unknown type name ‘guid_t’
>      5 | int acpi_call_prm_handler(guid_t handler_guid, void *param_buffer);
>        |                           ^~~~~~
> 
> The include file uses guid_t but it is not declared. Include
> linux/uuid.h to fix this.
> 
> Cc: Yazen Ghannam <Yazen.Ghannam@....com>
> Cc: John Allen <john.allen@....com>
> Cc: Borislav Petkov (AMD) <bp@...en8.de>
> Signed-off-by: Robert Richter <rrichter@....com>
> ---
>  include/linux/prmt.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/include/linux/prmt.h b/include/linux/prmt.h
> index 9c094294403f..c53ab287e932 100644
> --- a/include/linux/prmt.h
> +++ b/include/linux/prmt.h
> @@ -1,5 +1,7 @@
>  /* SPDX-License-Identifier: GPL-2.0-only */
>  
> +#include <linux/uuid.h>
> +
>  #ifdef CONFIG_ACPI_PRMT
>  void init_prmt(void);
>  int acpi_call_prm_handler(guid_t handler_guid, void *param_buffer);
> -- 

Hi Robert,

This looks correct. But can you please share how you've encountered the
issue?

Thanks,
Yazen