linux-kernel - Re: [PATCH] x86/entry: Add __init to ia32_emulation_override

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87a5c1b8a3.fsf@redhat.com>
Date: Wed, 08 Jan 2025 17:05:40 +0100
From: Vitaly Kuznetsov <vkuznets@...hat.com>
To: Andy Lutomirski <luto@...nel.org>, Thomas Gleixner <tglx@...utronix.de>,
 Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>, Dave
 Hansen <dave.hansen@...ux.intel.com>
Cc: x86@...nel.org, "H. Peter Anvin" <hpa@...or.com>, Nikolay Borisov
 <nik.borisov@...e.com>, Michael Petlan <mpetlan@...hat.com>,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86/entry: Add __init to ia32_emulation_override_cmdline()

Vitaly Kuznetsov <vkuznets@...hat.com> writes:

> ia32_emulation_override_cmdline() is an early_param() arg and these
> are only needed at boot time. In fact, all other early_param() functions
> in arch/x86 seem to have '__init' annotation and
> ia32_emulation_override_cmdline() is the only exception.
>
> Fixes: a11e097504ac ("x86: Make IA32_EMULATION boot time configurable")
> Signed-off-by: Vitaly Kuznetsov <vkuznets@...hat.com>
> ---
>  arch/x86/entry/common.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/entry/common.c b/arch/x86/entry/common.c
> index 94941c5a10ac..51efd2da4d7f 100644
> --- a/arch/x86/entry/common.c
> +++ b/arch/x86/entry/common.c
> @@ -142,7 +142,7 @@ static __always_inline int syscall_32_enter(struct pt_regs *regs)
>  #ifdef CONFIG_IA32_EMULATION
>  bool __ia32_enabled __ro_after_init = !IS_ENABLED(CONFIG_IA32_EMULATION_DEFAULT_DISABLED);
>  
> -static int ia32_emulation_override_cmdline(char *arg)
> +static int __init ia32_emulation_override_cmdline(char *arg)
>  {
>  	return kstrtobool(arg, &__ia32_enabled);
>  }

Post-holidays ping)

-- 
Vitaly