linux-kernel - Re: [PATCH net 1/9] mptcp: sysctl: avail sched: remove write access

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANn89iLPDTRYEGO0C=gtbHnM=OUPhfdK3RoLzzWMOMLEgmT0Tw@mail.gmail.com>
Date: Wed, 8 Jan 2025 17:25:54 +0100
From: Eric Dumazet <edumazet@...gle.com>
To: "Matthieu Baerts (NGI0)" <matttbe@...nel.org>
Cc: mptcp@...ts.linux.dev, Mat Martineau <martineau@...nel.org>, 
	Geliang Tang <geliang@...nel.org>, "David S. Miller" <davem@...emloft.net>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, 
	Gregory Detal <gregory.detal@...il.com>, 
	Marcelo Ricardo Leitner <marcelo.leitner@...il.com>, Xin Long <lucien.xin@...il.com>, 
	Vlad Yasevich <vyasevich@...il.com>, Neil Horman <nhorman@...driver.com>, 
	wangweidong <wangweidong1@...wei.com>, Daniel Borkmann <daniel@...earbox.net>, 
	Vlad Yasevich <vyasevic@...hat.com>, Allison Henderson <allison.henderson@...cle.com>, 
	Sowmini Varadhan <sowmini.varadhan@...cle.com>, Al Viro <viro@...iv.linux.org.uk>, 
	Joel Granados <joel.granados@...nel.org>, netdev@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-sctp@...r.kernel.org, 
	linux-rdma@...r.kernel.org, rds-devel@....oracle.com, stable@...r.kernel.org
Subject: Re: [PATCH net 1/9] mptcp: sysctl: avail sched: remove write access

On Wed, Jan 8, 2025 at 4:35 PM Matthieu Baerts (NGI0)
<matttbe@...nel.org> wrote:
>
> 'net.mptcp.available_schedulers' sysctl knob is there to list available
> schedulers, not to modify this list.
>
> There are then no reasons to give write access to it.
>
> Nothing would have been written anyway, but no errors would have been
> returned, which is unexpected.
>
> Fixes: 73c900aa3660 ("mptcp: add net.mptcp.available_schedulers")
> Cc: stable@...r.kernel.org
> Reviewed-by: Mat Martineau <martineau@...nel.org>
> Signed-off-by: Matthieu Baerts (NGI0) <matttbe@...nel.org>

Reviewed-by: Eric Dumazet <edumazet@...gle.com>