linux-kernel - Re: [PATCH v5 1/7] dt-bindings: display: mediatek: dpi: add power-domains property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <173635697547.725897.5297567835361998238.robh@kernel.org>
Date: Wed, 08 Jan 2025 11:22:55 -0600
From: "Rob Herring (Arm)" <robh@...nel.org>
To: amergnat@...libre.com
Cc: Thomas Zimmermann <tzimmermann@...e.de>, 
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, 
 Chun-Kuang Hu <chunkuang.hu@...nel.org>, 
 Krzysztof Kozlowski <krzk+dt@...nel.org>, 
 linux-arm-kernel@...ts.infradead.org, dri-devel@...ts.freedesktop.org, 
 Maxime Ripard <mripard@...nel.org>, Fabien Parent <fparent@...libre.com>, 
 Will Deacon <will@...nel.org>, Catalin Marinas <catalin.marinas@....com>, 
 Matthias Brugger <matthias.bgg@...il.com>, 
 linux-mediatek@...ts.infradead.org, devicetree@...r.kernel.org, 
 Philipp Zabel <p.zabel@...gutronix.de>, 
 Simona Vetter <simona.vetter@...ll.ch>, CK Hu <ck.hu@...iatek.com>, 
 David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>, 
 linux-kernel@...r.kernel.org, Jitao Shi <jitao.shi@...iatek.com>, 
 Conor Dooley <conor+dt@...nel.org>, 
 AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
Subject: Re: [PATCH v5 1/7] dt-bindings: display: mediatek: dpi: add
 power-domains property

On Wed, 08 Jan 2025 17:15:43 +0100, amergnat@...libre.com wrote:
> From: Fabien Parent <fparent@...libre.com>
> 
> DPI is part of the display / multimedia block in MediaTek SoCs, and
> always have a power-domain (at least in the upstream device-trees).
> Add the power-domains property to the binding documentation.
> 
> Fixes: 9273cf7d3942 ("dt-bindings: display: mediatek: convert the dpi bindings to yaml")
> Signed-off-by: Fabien Parent <fparent@...libre.com>
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
> Acked-by: Rob Herring (Arm) <robh@...nel.org>
> Reviewed-by: CK Hu <ck.hu@...iatek.com>
> Signed-off-by: Alexandre Mergnat <amergnat@...libre.com>
> ---
>  Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml | 5 +++++
>  1 file changed, 5 insertions(+)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:
./Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml:100:3: [error] duplication of key "power-domains" in mapping (key-duplicates)

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml: ignoring, error parsing file
./Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml:100:3: found duplicate key "power-domains" with value "{}" (original value: "{}")
make[2]: *** Deleting file 'Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.example.dts'
Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml:100:3: found duplicate key "power-domains" with value "{}" (original value: "{}")
make[2]: *** [Documentation/devicetree/bindings/Makefile:26: Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.example.dts] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1506: dt_binding_check] Error 2
make: *** [Makefile:251: __sub-make] Error 2

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20231023-display-support-v5-1-3905f1e4b835@baylibre.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.