linux-kernel - Re: [PATCH] perf hist: Fix width calculation in hpp_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c2d6551a-2345-4d6c-a0ec-06096a4d3a21@linaro.org>
Date: Wed, 8 Jan 2025 17:41:55 +0000
From: James Clark <james.clark@...aro.org>
To: Dmitry Vyukov <dvyukov@...gle.com>
Cc: linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org,
 namhyung@...nel.org, irogers@...gle.com
Subject: Re: [PATCH] perf hist: Fix width calculation in hpp__fmt()



On 08/01/2025 5:26 pm, James Clark wrote:
> 
> 
> On 08/01/2025 6:59 am, Dmitry Vyukov wrote:
>> hpp__width_fn() round up width to length of the field name,
>> hpp__fmt() should do it too. Otherwise, the numbers may
>> end up unaligned if the field name is long.
>>
>> Signed-off-by: Dmitry Vyukov <dvyukov@...gle.com>
>> Cc: Namhyung Kim <namhyung@...nel.org>
>> Cc: Ian Rogers <irogers@...gle.com>
>> Cc: linux-perf-users@...r.kernel.org
>> Cc: linux-kernel@...r.kernel.org
>> ---
>>   tools/perf/ui/hist.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tools/perf/ui/hist.c b/tools/perf/ui/hist.c
>> index e5491995adf08..34fda1d5eccb4 100644
>> --- a/tools/perf/ui/hist.c
>> +++ b/tools/perf/ui/hist.c
>> @@ -121,7 +121,7 @@ int hpp__fmt(struct perf_hpp_fmt *fmt, struct 
>> perf_hpp *hpp,
>>            const char *fmtstr, hpp_snprint_fn print_fn,
>>            enum perf_hpp_fmt_type fmtype)
>>   {
>> -    int len = fmt->user_len ?: fmt->len;
>> +    int len = max(fmt->user_len ?: fmt->len, (int)strlen(fmt->name));
>>       if (symbol_conf.field_sep) {
>>           return __hpp__fmt(hpp, he, get_field, fmtstr, 1,
>>
>> base-commit: 09a0fa92e5b45e99cf435b2fbf5ebcf889cf8780
> 
> This seems to right align the field correctly with a long name. Although 
> it's worth noting I had to add a long name to make it obvious.
> 
> Reviewed-by: James Clark <james.clark@...aro.org>
> 
> I saw some other existing issue with small column-width arguments which 
> is changed slightly by this patch. But I don't think it's worse:
> 

Ah maybe I was looking at it wrong, before and after are the same with 
width=3, apart from the intended fix. False alarm.

> 
> $ perf report --fields 
> overhead,overhead_sys,overhead_us,overhead_guest_us,dso --column- 
> widths=3,3,3,3,3
> 
> After:
> ------
> Overhead       sys       usr  guest usr long name  Shared Object
>    63.78%     0.00%    63.78%                0.00%  ld-linux-x86-64.so
> 
> After, width=3:
> --------------
> Overhead       sys       usr  guest usr long name  Sha
>    63.78%   0.00%     63.78%                 0.00%  ld-
> 
> Before:
> ---------------
> Overhead       sys       usr  guest usr long name  Shared Object
>    63.78%     0.00%    63.78%      0.00%            ld-linux-x86-64.so
> 
> Before, width=3:
> ---------------
> Overhead       sys       usr  guest usr long name  Sha
>   63.78%    0.00%     63.78%    0.00%               ld-