linux-kernel - Re: [PATCH] bpf: Replace (arg_type & MEM_RDONLY) with type_is_rdonly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAADnVQLGhwzqkMiBSfsQWgz=BqWZRxXAL+MP_Q3hSzie_PQ+_Q@mail.gmail.com>
Date: Wed, 8 Jan 2025 09:53:41 -0800
From: Alexei Starovoitov <alexei.starovoitov@...il.com>
To: Stanislav Fomichev <stfomichev@...il.com>
Cc: Feng Yang <yangfeng59949@....com>, Alexei Starovoitov <ast@...nel.org>, 
	Daniel Borkmann <daniel@...earbox.net>, John Fastabend <john.fastabend@...il.com>, 
	Andrii Nakryiko <andrii@...nel.org>, Martin KaFai Lau <martin.lau@...ux.dev>, Eddy Z <eddyz87@...il.com>, 
	Song Liu <song@...nel.org>, Yonghong Song <yonghong.song@...ux.dev>, KP Singh <kpsingh@...nel.org>, 
	Stanislav Fomichev <sdf@...ichev.me>, Hao Luo <haoluo@...gle.com>, Jiri Olsa <jolsa@...nel.org>, 
	bpf <bpf@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] bpf: Replace (arg_type & MEM_RDONLY) with type_is_rdonly_mem

On Tue, Jan 7, 2025 at 3:02 PM Stanislav Fomichev <stfomichev@...il.com> wrote:
>
> On 01/07, Feng Yang wrote:
> > From: Feng Yang <yangfeng@...inos.cn>
> >
> > The existing 'type_is_rdonly_mem' function is more formal in linux source
> >
> > Signed-off-by: Feng Yang <yangfeng@...inos.cn>
>
> Looks ok, but I'm not sure this cleanup is worth it on its own..
>
> Acked-by: Stanislav Fomichev <sdf@...ichev.me>

Yeah.
If we do this let's change type_is_rdonly_mem(u32 type)
to enum as well.

pw-bot: cr