linux-kernel - Re: [PATCH] perf: Fix a wrong help message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z368F9OnLGzluA5r@google.com>
Date: Wed, 8 Jan 2025 09:55:35 -0800
From: Namhyung Kim <namhyung@...nel.org>
To: Jiachen Zhang <me@...x.top>
Cc: linux-kernel@...r.kernel.org, Peter Zijlstra <peterz@...radead.org>,
	Ingo Molnar <mingo@...hat.com>,
	Arnaldo Carvalho de Melo <acme@...nel.org>,
	Mark Rutland <mark.rutland@....com>,
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
	Jiri Olsa <jolsa@...nel.org>, Ian Rogers <irogers@...gle.com>,
	Adrian Hunter <adrian.hunter@...el.com>,
	"Liang, Kan" <kan.liang@...ux.intel.com>,
	"open list:PERFORMANCE EVENTS SUBSYSTEM" <linux-perf-users@...r.kernel.org>
Subject: Re: [PATCH] perf: Fix a wrong help message

Hello,

On Thu, Jan 09, 2025 at 12:36:57AM +0800, Jiachen Zhang wrote:
> The wrong help message may mislead users. This commit fixes it.
> 
> Fixes: 328ccdace885 ("perf report: Add --no-demangle option")
> Signed-off-by: Jiachen Zhang <me@...x.top>
> ---
>  tools/perf/builtin-report.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
> index 048c91960ba9..a286d156510a 100644
> --- a/tools/perf/builtin-report.c
> +++ b/tools/perf/builtin-report.c
> @@ -1422,7 +1422,7 @@ int cmd_report(int argc, const char **argv)
>  	OPT_STRING(0, "addr2line", &addr2line_path, "path",
>  		   "addr2line binary to use for line numbers"),
>  	OPT_BOOLEAN(0, "demangle", &symbol_conf.demangle,
> -		    "Disable symbol demangling"),
> +		    "Enable symbol demangling"),

Maybe this is better: "Enable symbol demangling.  Use --no-demangle to disable."

Thanks,
Namhyung


>  	OPT_BOOLEAN(0, "demangle-kernel", &symbol_conf.demangle_kernel,
>  		    "Enable kernel symbol demangling"),
>  	OPT_BOOLEAN(0, "mem-mode", &report.mem_mode, "mem access profile"),
> -- 
> 2.34.1
>