linux-kernel - Re: [PATCH] sunrpc: clean cache_detail immediately when flush is written frequently

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <173636224524.14442.18042606814897132165.b4-ty@oracle.com>
Date: Wed,  8 Jan 2025 13:51:58 -0500
From: cel@...nel.org
To: trondmy@...nel.org,
	anna@...nel.org,
	jlayton@...nel.org,
	neilb@...e.de,
	okorniev@...hat.com,
	Dai.Ngo@...cle.com,
	tom@...pey.com,
	davem@...emloft.net,
	edumazet@...gle.com,
	kuba@...nel.org,
	pabeni@...hat.com,
	horms@...nel.org,
	Li Lingfeng <lilingfeng3@...wei.com>
Cc: Chuck Lever <chuck.lever@...cle.com>,
	linux-nfs@...r.kernel.org,
	netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	liujian56@...wei.com,
	yukuai1@...weicloud.com,
	houtao1@...wei.com,
	yi.zhang@...wei.com,
	yangerkun@...wei.com,
	lilingfeng@...weicloud.com
Subject: Re: [PATCH] sunrpc: clean cache_detail immediately when flush is written frequently

From: Chuck Lever <chuck.lever@...cle.com>

On Fri, 27 Dec 2024 16:33:53 +0800, Li Lingfeng wrote:
> We will write /proc/net/rpc/xxx/flush if we want to clean cache_detail.
> This updates nextcheck to the current time and calls cache_flush -->
> cache_clean to clean cache_detail.
> If we write this interface again within one second, it will only increase
> flush_time and nextcheck without actually cleaning cache_detail.
> Therefore, if we keep writing this interface repeatedly within one second,
> flush_time and nextcheck will keep increasing, even far exceeding the
> current time, making it impossible to clear cache_detail through the flush
> interface or cache_cleaner.
> If someone frequently calls the flush interface, we should immediately
> clean the corresponding cache_detail instead of continuously accumulating
> nextcheck.
> 
> [...]

Applied to nfsd-testing, thanks!

[1/1] sunrpc: clean cache_detail immediately when flush is written frequently
      commit: 33c4c54ed3b912edca4c2cd9ae3dd0492ab9fc4c

--
Chuck Lever