linux-kernel - RE: [PATCH next] scsi: fnic: silence uninitialized variable warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <SJ0PR11MB5896580318AA84057145A0CAC3122@SJ0PR11MB5896.namprd11.prod.outlook.com>
Date: Wed, 8 Jan 2025 19:05:37 +0000
From: "Karan Tilak Kumar (kartilak)" <kartilak@...co.com>
To: Dan Carpenter <dan.carpenter@...aro.org>
CC: "Satish Kharat (satishkh)" <satishkh@...co.com>, "Sesidhar Baddela
 (sebaddel)" <sebaddel@...co.com>, "James E.J. Bottomley"
	<James.Bottomley@...senpartnership.com>, "Martin K. Petersen"
	<martin.petersen@...cle.com>, "Arulprabhu Ponnusamy (arulponn)"
	<arulponn@...co.com>, "Gian Carlo Boffa (gcboffa)" <gcboffa@...co.com>, "Arun
 Easi (aeasi)" <aeasi@...co.com>, "linux-scsi@...r.kernel.org"
	<linux-scsi@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "kernel-janitors@...r.kernel.org"
	<kernel-janitors@...r.kernel.org>
Subject: RE: [PATCH next] scsi: fnic: silence uninitialized variable warning

On Wednesday, January 8, 2025 1:16 AM, Dan Carpenter <dan.carpenter@...aro.org> wrote:
>
> The debug code prints "oxid" but it isn't always initialized.
>
> Fixes: f828af44b8dd ("scsi: fnic: Add support for unsolicited requests and responses")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
> ---
> drivers/scsi/fnic/fdls_disc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/fnic/fdls_disc.c b/drivers/scsi/fnic/fdls_disc.c
> index 2534af2fff53..7928f94d3202 100644
> --- a/drivers/scsi/fnic/fdls_disc.c
> +++ b/drivers/scsi/fnic/fdls_disc.c
> @@ -3904,7 +3904,7 @@ fdls_process_abts_req(struct fnic_iport_s *iport, struct fc_frame_header *fchdr)
> uint8_t *frame;
> struct fc_std_abts_ba_acc *pba_acc;
> uint32_t nport_id;
> -     uint16_t oxid;
> +     uint16_t oxid = 0;
> struct fnic_tport_s *tport;
> struct fnic *fnic = iport->fnic;
> uint16_t frame_size = FNIC_ETH_FCOE_HDRS_OFFSET +
> --
> 2.45.2
>
>

The change look good. Thanks!
Reviewed-by: Karan Tilak Kumar <kartilak@...co.com>

Regards,
Karan