linux-kernel - Re: [PATCH net-next v2 06/14] net: ethernet: qualcomm: Initialize the PPE scheduler settings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4abc7542-df10-4bb6-a8dc-68e57789fc8e@wanadoo.fr>
Date: Wed, 8 Jan 2025 20:27:17 +0100
From: Christophe JAILLET <christophe.jaillet@...adoo.fr>
To: Luo Jie <quic_luoj@...cinc.com>, Andrew Lunn <andrew+netdev@...n.ch>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Lei Wei <quic_leiwei@...cinc.com>,
 Suruchi Agarwal <quic_suruchia@...cinc.com>,
 Pavithra R <quic_pavir@...cinc.com>, Simon Horman <horms@...nel.org>,
 Jonathan Corbet <corbet@....net>, Kees Cook <kees@...nel.org>,
 "Gustavo A. R. Silva" <gustavoars@...nel.org>,
 Philipp Zabel <p.zabel@...gutronix.de>
Cc: linux-arm-msm@...r.kernel.org, netdev@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-doc@...r.kernel.org, linux-hardening@...r.kernel.org,
 quic_kkumarcs@...cinc.com, quic_linchen@...cinc.com,
 srinivas.kandagatla@...aro.org, bartosz.golaszewski@...aro.org,
 john@...ozen.org
Subject: Re: [PATCH net-next v2 06/14] net: ethernet: qualcomm: Initialize the
 PPE scheduler settings

Le 08/01/2025 à 14:47, Luo Jie a écrit :
> The PPE scheduler settings determine the priority of scheduling the
> packet across the different hardware queues per PPE port.
> 
> Signed-off-by: Luo Jie <quic_luoj@...cinc.com>

...

> +/* Scheduler configuration for dispatching packet on PPE queues, which
> + * is different per SoC.
> + */
> +static struct ppe_scheduler_qm_config ipq9574_ppe_sch_qm_config[] = {
> +	{0x98, 6, 0, 1, 1},
> +	{0x94, 5, 6, 1, 3},

This could certainly be declared as const.
If agreed, some other arrays in this patch in some other patch could 
also be constified.

CJ